Resolving PR comments #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
force-pushed
the
james-changes
branch
from
5787286 to
b1c5d84
Compare
jamesbraza
force-pushed
the
james-changes
branch
from
b1c5d84 to
16b3d09
Compare
jamesbraza
commented
Jan 23, 2025
| @@ -368,25 +358,26 @@ async def call_single( | |||
| return results[0] | |||
|
|
|||
|
|
|||
| LLMModelOrChild = TypeVar("LLMModelOrChild", bound=LLMModel) | |||
| P = ParamSpec("P") | |||
mskarlin
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
This looks good to me, the initial intention to limit this to working with LLMModelOrChild was because it was tightly coupled to LLMModel methods (so it was typed as such to handle the self input for the methods) -- it makes sense that swapping to a ParamSpec worked, but I'm not clear on how the ModelResponse types ever worked or what they were meant to capture since the LLMModel methods are returning Chunk types.
maykcaldas
added a commit
that referenced
this pull request
Jan 24, 2025
* WIP: commited partially refactored llms to merge from main * Removed Chunk. Now LiteLLMModel's methods return a LLMResult * Refactored LiteLLMModel and MultipleCompletionsLLMModel MultipleCompletionsLLMModel is deprecated * updated tests * Updated uv.lock for new uv version * Updated test checking if an asyncIterator was a list * Reverted uv.lock changes * calling async callbacks with asyncio.gather * Dropped support to run_prompt * Updated cassettes for test_call * Fixed typing of llm_result_callback * Fix reburb error * added missing new cassette * Removed support to completion models This also renamed achat to acompletion to align better with litellm interface * Updated uv.lock It seems some entries had the old 'platform_system' marker due my old uv version. Now it is updated to 'sys_platform' * added typeguard to pyproject.toml * Fixed rate_limited typing * Fixed typing check in rate_limited * Avoided vcr for test_call_w_figure * Casting results in rate_limited to avoid type ignoring * Prepared to get deepseek reasoning from litellm Waiting for their release to validate this commit * Added atext_completion back to PassThroughRouter * Renamed LLM models in tests with more caution gpt-4o-mini was renamed to OPENAI_TEST, gpt-4o to GPT_4O, and gpt-3.5-turbo to GPT_35. As support to gpt-3.5-turbo-instruct was dropped, these tests were adapted to ANTHROPIC_TEST * Ruff fix * Implemented logprobs calculation in streaming response * Added .mailmap so pre-commit passes * Many fixes to typing in llms * Formatted cassettes * added deepseek test * Bumped litellm version for deepseek * Getting reasoning_content from deepseek models * Resolving PR comments (#39) * Added .mailmap so pre-commit passes * Many fixes to typing in llms * Formatted cassettes * Removed litellm from dev and removed python version checking * Changed attribute description for reasoning_content * removed deprecated MultipleCompletionLLMModel from llm.__all__ * adding formatted uv.lock * Fixing LiteLLM `Router.acompletion` typing issue (#43) * Cleaned up cassettes --------- Co-authored-by: James Braza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rate_limiteddecorator doesn't pass type checker #33 by battlingrate_limitedfor a whilelist[float].mailmapresultlocal