Renamed LLMModel.name to LLMModel.model #47
Closed
+44
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a renaming. No new feature is implemented. Reasoning behind the renaming:
-
pqa
expects to receive aname
to itsLLM
. This name is used to create the config aslitellm.router
expects it, if not provided. Amodel_list
is created and added to the config:ldp
uses amodel
keyword to refer to the name.I am proposing this change because I think
model
is more aligned withlitellm
nomenclature. Then, opening this PR to get feedback on that