Fixed invalid MMR argsort

Future-House · Mar 8, 2024 · 01304f1 · 01304f1
1 parent 0d63f6f
commit 01304f1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/paperqa/llms.py b/paperqa/llms.py
@@ -609,10 +609,9 @@ async def similarity_search(
         )[0]
         similarity_scores = np.nan_to_num(similarity_scores, nan=-np.inf)
         # minus so descending
-        if k == len(self.texts):
-            sorted_indices = np.argsort(-similarity_scores)
-        else:
-            sorted_indices = np.argpartition(-similarity_scores, k)
+        # we could use arg-partition here
+        # but a lot of algorithms expect a sorted list
+        sorted_indices = np.argsort(-similarity_scores)
         return (
             [self.texts[i] for i in sorted_indices[:k]],
             [similarity_scores[i] for i in sorted_indices[:k]],

diff --git a/paperqa/version.py b/paperqa/version.py
@@ -1 +1 @@
-__version__ = "4.1.0"
+__version__ = "4.1.1"