Skip to content

Commit

Permalink
Fixing crash if json.loads returns a string
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesbraza committed Mar 8, 2024
1 parent 104a652 commit 2cca774
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions paperqa/docs.py
Original file line number Diff line number Diff line change
Expand Up @@ -705,20 +705,17 @@ async def process(match):
# fetch from markdown ```json if present
context = context.split("```json")[-1].split("```")[0]
result_data = json.loads(context)
success = isinstance(result_data, dict)
except json.decoder.JSONDecodeError:
# fallback to string
success = False
if success:
try:
context = result_data["summary"]
score = result_data["relevance_score"]
del result_data["summary"]
del result_data["relevance_score"]
if "question" in result_data:
del result_data["question"]
context = result_data.pop("summary")
score = result_data.pop("relevance_score")
result_data.pop("question", None)
extras = result_data
except KeyError:
# fallback
success = False
# fallback to string (or json mode not enabled)
if not success or not self.prompts.summary_json:
Expand Down

0 comments on commit 2cca774

Please sign in to comment.