Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev extra and cleaned up CI #263

Merged
merged 3 commits into from
Mar 30, 2024
Merged

dev extra and cleaned up CI #263

merged 3 commits into from
Mar 30, 2024

Conversation

jamesbraza
Copy link
Collaborator

  • Enables pip install -e .[dev] and moves CI to use this
  • Uses the latest GitHub Actions versions
  • Alphabetizes and groups dev-requirements.txt

@jamesbraza jamesbraza added the enhancement New feature or request label Mar 30, 2024
@jamesbraza jamesbraza requested a review from whitead March 30, 2024 04:25
@jamesbraza jamesbraza self-assigned this Mar 30, 2024
whitead
whitead approved these changes Mar 30, 2024
View reviewed changes
Copy link
Collaborator

@whitead whitead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying the build! Assuming it doesn't need to be installed for building wheels based on your commit - good to know!

@jamesbraza
Copy link
Collaborator Author

I tested pip install .[dev] && python -m build --sdist --wheel --outdir dist/ . works just now to be sure

@jamesbraza jamesbraza merged commit 67b05ac into main Mar 30, 2024
1 check passed
@jamesbraza jamesbraza deleted the installing-dev branch March 30, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitead whitead whitead approved these changes

Assignees

@jamesbraza jamesbraza

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @whitead