Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delaying of state mutation in Docs.aadd_texts #264

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Delaying of state mutation in Docs.aadd_texts #264

merged 1 commit into from
Mar 30, 2024

Conversation

jamesbraza
Copy link
Collaborator

Delaying mutation of Docs, Doc, and Texts in Docs.aadd_texts until after embed_documents completes

This enables callers to retry in the event of openai.RateLimitError

@jamesbraza jamesbraza added the enhancement New feature or request label Mar 30, 2024
@jamesbraza jamesbraza requested a review from whitead March 30, 2024 05:25
@jamesbraza jamesbraza self-assigned this Mar 30, 2024
@jamesbraza jamesbraza requested a review from mskarlin March 30, 2024 05:25
whitead
whitead approved these changes Mar 30, 2024
View reviewed changes
Copy link
Collaborator

@whitead whitead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart idea - LGTM!

@whitead whitead merged commit 4457c34 into main Mar 30, 2024
1 check passed
@whitead whitead deleted the allowing-openai-retry branch March 30, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitead whitead whitead approved these changes

@mskarlin mskarlin Awaiting requested review from mskarlin

Assignees

@jamesbraza jamesbraza

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @whitead