Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vastly reducing chances of flaky test_docs_pickle #265

Closed
wants to merge 1 commit into from
Closed

Vastly reducing chances of flaky test_docs_pickle #265

wants to merge 1 commit into from

Conversation

jamesbraza
Copy link
Collaborator

test_docs_pickle is a flaky test:

  1. https://github.com/whitead/paper-qa/pull/249 added 4X retrying
  2. https://github.com/whitead/paper-qa/pull/250 lowered the threshold similarity

This PR just doubles the retrying count to 8X

@jamesbraza jamesbraza added the bug Something isn't working label Mar 30, 2024
@jamesbraza jamesbraza requested a review from whitead March 30, 2024 07:08
@jamesbraza jamesbraza self-assigned this Mar 30, 2024
@jamesbraza
Copy link
Collaborator Author

Green CI checkmark, lame code. Closing this out as it just basically masks the real issue, that the SUT's internals are not repeatable

@jamesbraza jamesbraza closed this Mar 30, 2024
@jamesbraza jamesbraza deleted the flaky-test-pickle branch March 30, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitead whitead Awaiting requested review from whitead

Assignees

@jamesbraza jamesbraza

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamesbraza