Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beta: Enable mypy #423

Merged
merged 1 commit into from
Dec 27, 2024
Merged

beta: Enable mypy #423

merged 1 commit into from
Dec 27, 2024

Conversation

Snuffy2
Copy link
Contributor

@Snuffy2 Snuffy2 commented Dec 17, 2024 •
edited
Loading

Proposed change

mypy wasn't actually enabled in pyproject.toml. This enables it and updates the code to pass mypy.
pytest is still not setup/working

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

@Snuffy2 Snuffy2 changed the base branch from main to beta December 17, 2024 02:10
@Snuffy2 Snuffy2 marked this pull request as ready for review December 27, 2024 17:19
@firstof9 firstof9 merged commit 200ef12 into FutureTense:beta Dec 27, 2024
3 of 4 checks passed
@Snuffy2 Snuffy2 deleted the Enable-mypy branch December 27, 2024 23:08
This was referenced Dec 28, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Snuffy2 @firstof9