Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit user role table changes null out the user's email #6103

Closed
2 tasks
petertgiles opened this issue Mar 29, 2023 · 0 comments · Fixed by #6111
Closed
2 tasks

Edit user role table changes null out the user's email #6103

petertgiles opened this issue Mar 29, 2023 · 0 comments · Fixed by #6111
Assignees
Labels
bug Something isn't working.

Comments

@petertgiles
Copy link
Contributor

🐛 Bug

The role tables on the edit user page use the same mutation from the edit user page itself. However, this mutation is set to null out empty email addresses. Since the role dialogs do not provide an email address they null out the email field for the user.

🦋 Expected Behaviour

Role edits should not affect the user's email address

🕵️ Details

It seems like this behaviour was added in #4103.

📋 Steps to Reproduce

  1. Navigate to http://localhost:8000/en/admin/users/{userId}/edit
  2. Ensure the user has an email address in their profile
  3. Make any role change
  4. Observe that the email is gone

📸 Screenshot

image.pngAdd a screenshot (if possible).

🙋‍♀️ Proposed Solution

Perhaps the page should pass a separate mutation to the role tables? Or the role tables should manage their own mutations?

✅ Acceptance Criteria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants