[Bug] Fix user role from removing email #6111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π€ Resolves #6103
π Introduction
This prevents role updates from overriding the user email to
null
.π΅οΈ Details
We were setting the users email to
null
when it did not exist (either undefined or empty string) to prevent our validation from seeing""
as a duplicate email. This unsets the email key in our mutation variables if it is undefined so that it is only nulled when it is an empty string.π§ͺ Testing
Assist reviewers with steps they can take to test that the PR does what it says it does.
npm run build