Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow troubleshooting #3361

Merged
merged 3 commits into from
Jul 18, 2022
Merged

workflow troubleshooting #3361

merged 3 commits into from
Jul 18, 2022

Conversation

vd1992
Copy link
Contributor

@vd1992 vd1992 commented Jul 15, 2022

trying to troubleshooting the docker/e2e issues...

okay, each commit represents a solution to the recent issue of workflows for smoketest and cypress
both appear to resolve the issue, I am partial to the latter since I do not know if there is a purpose to the postrun save, disabling it solves the issue for sure and shaves some time off test runs

Screen Shot 2022-07-18 at 12 04 01 PM

related to docker layer caching action: satackey/action-docker-layer-caching#139 (comment)

per conversation here
https://talent-cloud.slack.com/archives/C0259G6KXJ6/p1657839973910039

@vd1992 vd1992 marked this pull request as ready for review July 15, 2022 18:42
@vd1992 vd1992 requested a review from patcon July 15, 2022 18:44
@vd1992
Copy link
Contributor Author

vd1992 commented Jul 15, 2022

looking at some previous runs, this one for example, post-run took 6 minutes
https://github.com/GCTC-NTGC/gc-digital-talent/runs/7346142902?check_suite_focus=true

@vd1992 vd1992 requested a review from tristan-orourke July 15, 2022 19:31
@petertgiles
Copy link
Contributor

petertgiles commented Jul 18, 2022

What are the "docker/e2e issues"? I'm not sure what this branch is solving. Thanks for the link.

@patcon
Copy link
Contributor

patcon commented Jul 18, 2022

Nice! If I'm understanding correctly, 8782930 looks like it also resolved it by clearing up space on the VM? This feels like the least change to get things working.

(I believe that the skip-save: true alternative totally turns off updating of the cache, which is the same as removing the cache step.)

Preference is for the first solution 8782930, since it preserves caching. But if you do go with the skip-save option (because I'm missing some consideration), I'd propose adding a comment and maybe a TODO to "re-enable once PR #### is resolved", as my experience is that temporary work-arounds get forgotten if not annotated in code :)

Copy link
Contributor

@patcon patcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preference for solution in prior commit, unless I'm missing some consideration :)

@vd1992
Copy link
Contributor Author

vd1992 commented Jul 18, 2022

Preference for solution in prior commit, unless I'm missing some consideration :)

aye aye

@vd1992 vd1992 requested a review from patcon July 18, 2022 17:09
Copy link
Contributor

@patcon patcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vd1992
Copy link
Contributor Author

vd1992 commented Jul 18, 2022

Thanks!

workflows please cooperate now!

@vd1992 vd1992 merged commit 420081e into main Jul 18, 2022
@vd1992 vd1992 deleted the workflow/troubleshoot-workflows branch July 18, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants