Skip to content

Commit

Permalink
fix: 코드리뷰 반영
Browse files Browse the repository at this point in the history
  • Loading branch information
@eugene028
eugene028 committed Jun 7, 2024
1 parent 2ceb77e commit c9d5c14
Show file tree
Hide file tree
Showing 5 changed files with 67 additions and 84 deletions.
2 changes: 1 addition & 1 deletion .eslintcache
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
[{"/Users/eugene/github/wow-design-system/packages/wow-ui/src/components/Chip/Chip.stories.ts":"1","/Users/eugene/github/wow-design-system/packages/wow-ui/src/components/Chip/index.tsx":"2","/Users/eugene/github/wow-design-system/packages/wow-ui/src/types/button.ts":"3","/Users/eugene/github/wow-design-system/packages/wow-ui/src/types/index.ts":"4","/Users/eugene/github/wow-design-system/apps/wow-docs/app/page.tsx":"5","/Users/eugene/github/wow-design-system/packages/theme/src/color.ts":"6","/Users/eugene/github/wow-design-system/packages/wow-ui/src/types/Polymorphic.ts":"7","/Users/eugene/github/wow-design-system/packages/wow-icons/src/CloseButton.tsx":"8","/Users/eugene/github/wow-design-system/packages/wow-icons/src/index.ts":"9"},{"size":3427,"mtime":1717049872156,"results":"10","hashOfConfig":"11"},{"size":4991,"mtime":1717050685389,"results":"12","hashOfConfig":"11"},{"size":2014,"mtime":1716658340646,"results":"13","hashOfConfig":"11"},{"size":57,"mtime":1716631427241,"results":"14","hashOfConfig":"11"},{"size":489,"mtime":1717052438980,"results":"15","hashOfConfig":"11"},{"size":5061,"mtime":1716648586995,"results":"16","hashOfConfig":"11"},{"size":423,"mtime":1716631402622,"results":"17","hashOfConfig":"11"},{"size":328,"mtime":1716654901735,"results":"18","hashOfConfig":"11"},{"size":112,"mtime":1716654851710,"results":"19","hashOfConfig":"11"},{"filePath":"20","messages":"21","suppressedMessages":"22","errorCount":0,"fatalErrorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},"8oyd96",{"filePath":"23","messages":"24","suppressedMessages":"25","errorCount":0,"fatalErrorCount":0,"warningCount":4,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"26","messages":"27","suppressedMessages":"28","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"29","messages":"30","suppressedMessages":"31","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"32","messages":"33","suppressedMessages":"34","errorCount":0,"fatalErrorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"35","messages":"36","suppressedMessages":"37","errorCount":0,"fatalErrorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"38","messages":"39","suppressedMessages":"40","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"41","messages":"42","suppressedMessages":"43","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"44","messages":"45","suppressedMessages":"46","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"/Users/eugene/github/wow-design-system/packages/wow-ui/src/components/Chip/Chip.stories.ts",["47"],[],"/Users/eugene/github/wow-design-system/packages/wow-ui/src/components/Chip/index.tsx",["48","49","50","51"],[],"/Users/eugene/github/wow-design-system/packages/wow-ui/src/types/button.ts",[],[],"/Users/eugene/github/wow-design-system/packages/wow-ui/src/types/index.ts",[],[],"/Users/eugene/github/wow-design-system/apps/wow-docs/app/page.tsx",["52"],[],"/Users/eugene/github/wow-design-system/packages/theme/src/color.ts",["53"],[],"/Users/eugene/github/wow-design-system/packages/wow-ui/src/types/Polymorphic.ts",[],[],"/Users/eugene/github/wow-design-system/packages/wow-icons/src/CloseButton.tsx",[],[],"/Users/eugene/github/wow-design-system/packages/wow-icons/src/index.ts",[],[],{"ruleId":"54","severity":1,"message":"55","line":3,"column":18,"nodeType":"56","endLine":3,"endColumn":37},{"ruleId":"54","severity":1,"message":"57","line":2,"column":21,"nodeType":"56","endLine":2,"endColumn":41},{"ruleId":"54","severity":1,"message":"58","line":3,"column":24,"nodeType":"56","endLine":3,"endColumn":44},{"ruleId":"59","severity":1,"message":"60","line":7,"column":10,"nodeType":"61","messageId":"62","endLine":7,"endColumn":18},{"ruleId":"54","severity":1,"message":"63","line":7,"column":26,"nodeType":"56","endLine":7,"endColumn":62},{"ruleId":"54","severity":1,"message":"64","line":1,"column":21,"nodeType":"56","endLine":1,"endColumn":45},{"ruleId":"59","severity":1,"message":"65","line":4,"column":10,"nodeType":"61","messageId":"62","endLine":4,"endColumn":15},"import/no-unresolved","Unable to resolve path to module '@/components/Chip'.","Literal","Unable to resolve path to module '@styled-system/css'.","Unable to resolve path to module '@styled-system/jsx'.","no-unused-vars","'Disabled' is defined but never used.","Identifier","unusedVar","Unable to resolve path to module '@/components/Switch/Switch.stories'.","Unable to resolve path to module '@styled-system/css/css'.","'black' is defined but never used."]
[{"/Users/eugene/github/wow-design-system/packages/wow-ui/src/components/Chip/Chip.stories.ts":"1","/Users/eugene/github/wow-design-system/packages/wow-ui/src/components/Chip/index.tsx":"2","/Users/eugene/github/wow-design-system/packages/wow-ui/src/types/button.ts":"3","/Users/eugene/github/wow-design-system/packages/wow-ui/src/types/index.ts":"4","/Users/eugene/github/wow-design-system/apps/wow-docs/app/page.tsx":"5","/Users/eugene/github/wow-design-system/packages/wow-ui/src/types/Polymorphic.ts":"6","/Users/eugene/github/wow-design-system/packages/wow-icons/src/CloseButton.tsx":"7"},{"size":3427,"mtime":1717049872156,"results":"8","hashOfConfig":"9"},{"size":5010,"mtime":1717580527026,"results":"10","hashOfConfig":"11"},{"size":2033,"mtime":1717580378191,"results":"12","hashOfConfig":"11"},{"size":57,"mtime":1716631427241,"results":"13","hashOfConfig":"9"},{"size":489,"mtime":1717052438980,"results":"14","hashOfConfig":"9"},{"size":423,"mtime":1716631402622,"results":"15","hashOfConfig":"9"},{"size":328,"mtime":1716654901735,"results":"16","hashOfConfig":"9"},{"filePath":"17","messages":"18","suppressedMessages":"19","errorCount":0,"fatalErrorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},"8oyd96",{"filePath":"20","messages":"21","suppressedMessages":"22","errorCount":0,"fatalErrorCount":0,"warningCount":3,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},"8a6h2i",{"filePath":"23","messages":"24","suppressedMessages":"25","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"26","messages":"27","suppressedMessages":"28","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"29","messages":"30","suppressedMessages":"31","errorCount":0,"fatalErrorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"32","messages":"33","suppressedMessages":"34","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"35","messages":"36","suppressedMessages":"37","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"/Users/eugene/github/wow-design-system/packages/wow-ui/src/components/Chip/Chip.stories.ts",["38"],[],"/Users/eugene/github/wow-design-system/packages/wow-ui/src/components/Chip/index.tsx",["39","40","41"],[],"/Users/eugene/github/wow-design-system/packages/wow-ui/src/types/button.ts",[],[],"/Users/eugene/github/wow-design-system/packages/wow-ui/src/types/index.ts",[],[],"/Users/eugene/github/wow-design-system/apps/wow-docs/app/page.tsx",["42"],[],"/Users/eugene/github/wow-design-system/packages/wow-ui/src/types/Polymorphic.ts",[],[],"/Users/eugene/github/wow-design-system/packages/wow-icons/src/CloseButton.tsx",[],[],{"ruleId":"43","severity":1,"message":"44","line":3,"column":18,"nodeType":"45","endLine":3,"endColumn":37},{"ruleId":"43","severity":1,"message":"46","line":2,"column":21,"nodeType":"45","endLine":2,"endColumn":41},{"ruleId":"43","severity":1,"message":"47","line":3,"column":24,"nodeType":"45","endLine":3,"endColumn":44},{"ruleId":"48","severity":1,"message":"49","line":27,"column":18,"nodeType":"50","messageId":"51","endLine":27,"endColumn":28},{"ruleId":"43","severity":1,"message":"52","line":1,"column":21,"nodeType":"45","endLine":1,"endColumn":45},"import/no-unresolved","Unable to resolve path to module '@/components/Chip'.","Literal","Unable to resolve path to module '@styled-system/css'.","Unable to resolve path to module '@styled-system/jsx'.","@typescript-eslint/naming-convention","Interface name `_ChipProps` must match one of the following formats: PascalCase","Identifier","doesNotMatchFormat","Unable to resolve path to module '@styled-system/css/css'."]
72 changes: 36 additions & 36 deletions apps/wow-docs/styled-system/tokens/index.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -295,41 +295,41 @@ const tokens = {
value: "linear-gradient(to right, #FDE6B2, #FDDD99)",
variable: "var(--gradients-yellow-gradient-light)",
},
"spacing.spacing.xxs": {
"spacing.xxs": {
value: "0.25rem",
variable: "var(--spacing-spacing-xxs)",
variable: "var(--spacing-xxs)",
},
"spacing.spacing.xs": {
"spacing.xs": {
value: "0.5rem",
variable: "var(--spacing-spacing-xs)",
variable: "var(--spacing-xs)",
},
"spacing.spacing.sm": {
"spacing.sm": {
value: "0.75rem",
variable: "var(--spacing-spacing-sm)",
variable: "var(--spacing-sm)",
},
"spacing.spacing.md": {
"spacing.md": {
value: "1rem",
variable: "var(--spacing-spacing-md)",
variable: "var(--spacing-md)",
},
"spacing.spacing.lg": {
"spacing.lg": {
value: "1.25rem",
variable: "var(--spacing-spacing-lg)",
variable: "var(--spacing-lg)",
},
"spacing.spacing.xl": {
"spacing.xl": {
value: "1.5rem",
variable: "var(--spacing-spacing-xl)",
variable: "var(--spacing-xl)",
},
"radii.radius.sm": {
"radii.sm": {
value: "0.25rem",
variable: "var(--radii-radius-sm)",
variable: "var(--radii-sm)",
},
"radii.radius.md": {
"radii.md": {
value: "0.5rem",
variable: "var(--radii-radius-md)",
variable: "var(--radii-md)",
},
"radii.radius.full": {
"radii.full": {
value: "2.5rem",
variable: "var(--radii-radius-full)",
variable: "var(--radii-full)",
},
"borderWidths.button": {
value: "1px",
Expand Down Expand Up @@ -471,29 +471,29 @@ const tokens = {
value: "#000000",
variable: "var(--colors-github)",
},
"spacing.spacing.-xxs": {
value: "calc(var(--spacing-spacing-xxs) * -1)",
variable: "var(--spacing-spacing-xxs)",
"spacing.-xxs": {
value: "calc(var(--spacing-xxs) * -1)",
variable: "var(--spacing-xxs)",
},
"spacing.spacing.-xs": {
value: "calc(var(--spacing-spacing-xs) * -1)",
variable: "var(--spacing-spacing-xs)",
"spacing.-xs": {
value: "calc(var(--spacing-xs) * -1)",
variable: "var(--spacing-xs)",
},
"spacing.spacing.-sm": {
value: "calc(var(--spacing-spacing-sm) * -1)",
variable: "var(--spacing-spacing-sm)",
"spacing.-sm": {
value: "calc(var(--spacing-sm) * -1)",
variable: "var(--spacing-sm)",
},
"spacing.spacing.-md": {
value: "calc(var(--spacing-spacing-md) * -1)",
variable: "var(--spacing-spacing-md)",
"spacing.-md": {
value: "calc(var(--spacing-md) * -1)",
variable: "var(--spacing-md)",
},
"spacing.spacing.-lg": {
value: "calc(var(--spacing-spacing-lg) * -1)",
variable: "var(--spacing-spacing-lg)",
"spacing.-lg": {
value: "calc(var(--spacing-lg) * -1)",
variable: "var(--spacing-lg)",
},
"spacing.spacing.-xl": {
value: "calc(var(--spacing-spacing-xl) * -1)",
variable: "var(--spacing-spacing-xl)",
"spacing.-xl": {
value: "calc(var(--spacing-xl) * -1)",
variable: "var(--spacing-xl)",
},
"colors.colorPalette.50": {
value: "var(--colors-color-palette-50)",
Expand Down
56 changes: 28 additions & 28 deletions apps/wow-docs/styled-system/tokens/tokens.d.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,15 @@ export type Token =
| "gradients.greenGradientLight"
| "gradients.yellowGradientDark"
| "gradients.yellowGradientLight"
| "spacing.spacing.xxs"
| "spacing.spacing.xs"
| "spacing.spacing.sm"
| "spacing.spacing.md"
| "spacing.spacing.lg"
| "spacing.spacing.xl"
| "radii.radius.sm"
| "radii.radius.md"
| "radii.radius.full"
| "spacing.xxs"
| "spacing.xs"
| "spacing.sm"
| "spacing.md"
| "spacing.lg"
| "spacing.xl"
| "radii.sm"
| "radii.md"
| "radii.full"
| "borderWidths.button"
| "borderWidths.arrow"
| "breakpoints.sm"
Expand Down Expand Up @@ -118,12 +118,12 @@ export type Token =
| "colors.blueShadow"
| "colors.discord"
| "colors.github"
| "spacing.spacing.-xxs"
| "spacing.spacing.-xs"
| "spacing.spacing.-sm"
| "spacing.spacing.-md"
| "spacing.spacing.-lg"
| "spacing.spacing.-xl"
| "spacing.-xxs"
| "spacing.-xs"
| "spacing.-sm"
| "spacing.-md"
| "spacing.-lg"
| "spacing.-xl"
| "colors.colorPalette.50"
| "colors.colorPalette.100"
| "colors.colorPalette.150"
Expand Down Expand Up @@ -287,20 +287,20 @@ export type GradientToken =
| "yellowGradientLight";

export type SpacingToken =
| "spacing.xxs"
| "spacing.xs"
| "spacing.sm"
| "spacing.md"
| "spacing.lg"
| "spacing.xl"
| "-spacing.xxs"
| "-spacing.xs"
| "-spacing.sm"
| "-spacing.md"
| "-spacing.lg"
| "-spacing.xl";
| "xxs"
| "xs"
| "sm"
| "md"
| "lg"
| "xl"
| "-xxs"
| "-xs"
| "-sm"
| "-md"
| "-lg"
| "-xl";

export type RadiusToken = "radius.sm" | "radius.md" | "radius.full";
export type RadiusToken = "sm" | "md" | "full";

export type BorderWidthToken = "button" | "arrow";

Expand Down
17 changes: 0 additions & 17 deletions packages/wow-ui/src/components/Chip/Chip.stories.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,6 @@ const meta = {
componentSubtitle: "칩 컴포넌트",
},
argTypes: {
as: {
control: {
type: "select",
options: ["button", "div", "span"],
labels: {
button: "button",
div: "div",
span: "span",
},
},
description:
"as는 렌더링할 요소 또는 컴포넌트를 나타냅니다. 기본값은 button입니다. 칩의 경우 div, span으로도 사용 가능합니다.",
table: {
defaultValue: { summary: "button" },
type: { summary: "React.ElementType" },
},
},
disabled: {
description: "disabled는 칩 버튼이 비활성화 상태인지 여부를 나타냅니다.",
table: {
Expand Down
4 changes: 2 additions & 2 deletions packages/wow-ui/src/components/Chip/index.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ const Chip: ChipComponent & { displayName?: string } = forwardRef(
onClick={handleClick}
onKeyDown={handleKeyDown}
{...rest.customStyle}
aria-label={`chip button ${isChecked ? "activated" : "inactivated"}`}
aria-label={`chip ${isChecked ? "activated" : "inactivated"}`}
data-selected={isChecked}
>
<ChipLabel disabled={disabled} isChecked={isChecked} label={label} />
Expand Down Expand Up @@ -157,7 +157,7 @@ const chip = cva({
minWidth: "3.5rem",
height: "1.875rem",
borderRadius: "1.25rem",
padding: "0.5rem 0.75rem",
padding: "xs s",
},
variants: {
clickable: {
Expand Down

0 comments on commit c9d5c14

Please sign in to comment.