Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Spinner 컴포넌트 구현 #106

Merged
merged 22 commits into from
Aug 2, 2024
Merged

[Feature] Spinner 컴포넌트 구현 #106

merged 22 commits into from
Aug 2, 2024

Conversation

ghdtjgus76
Copy link
Collaborator

🎉 변경 사항

Spinner 컴포넌트 구현했습니다.

따로 테스트해볼 로직은 없는 거 같아서 테스트 코드는 작성하지 않았습니다.

🚩 관련 이슈

🙏 여기는 꼭 봐주세요!

@ghdtjgus76 ghdtjgus76 self-assigned this Jul 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-vwcimyihes.chromatic.com/

@ghdtjgus76 ghdtjgus76 linked an issue Jul 26, 2024 that may be closed by this pull request
[Feature] 스피너 컴포넌트 구현 #98
Closed
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-umzdnjfukz.chromatic.com/

SeieunYoo
SeieunYoo reviewed Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@SeieunYoo SeieunYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨어용~!

packages/wow-ui/package.json Show resolved Hide resolved
packages/wow-ui/src/components/Spinner/BlueSpinner.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-cxdhordgqn.chromatic.com/

SeieunYoo
SeieunYoo reviewed Jul 28, 2024
View reviewed changes
Copy link
Collaborator

@SeieunYoo SeieunYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~>~

packages/wow-ui/package.json Show resolved Hide resolved
packages/wow-ui/src/components/Spinner/BlueSpinner.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-jgxtvlvjad.chromatic.com/

@ghdtjgus76 ghdtjgus76 requested a review from SeieunYoo July 29, 2024 12:50
SeieunYoo
SeieunYoo approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@SeieunYoo SeieunYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아용 수고 많으셨습니다!!
나중에 다른 로띠 컴포넌트도 생기면 LottieBase 같은 컴포넌트 만들어서 확장해도 좋을 것 같네욤

eugene028
eugene028 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@eugene028 eugene028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰가 늦었네용 🥹 수고하셨습니다

@ghdtjgus76 ghdtjgus76 merged commit 5af6297 into main Aug 2, 2024
3 checks passed
@ghdtjgus76 ghdtjgus76 deleted the feature/spinner-component branch August 2, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeieunYoo SeieunYoo SeieunYoo approved these changes

@eugene028 eugene028 eugene028 approved these changes

@hamo-o hamo-o Awaiting requested review from hamo-o hamo-o is a code owner

@kongnayeon kongnayeon Awaiting requested review from kongnayeon

Assignees

@ghdtjgus76 ghdtjgus76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] 스피너 컴포넌트 구현
3 participants
@ghdtjgus76 @eugene028 @SeieunYoo