-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] 버튼 컴포넌트 추가 스펙 구현 #136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamo-o
requested review from
ghdtjgus76,
eugene028 and
SeieunYoo
as code owners
August 12, 2024 16:25
4 tasks
SeieunYoo
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
머지고고~~
+) changeset 도 추가해서 button 수정버전 배포되면 좋을 거 같아요!
ghdtjgus76
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿굿 제가 이전에 올린 pr은 닫아둘게요~
hamo-o
force-pushed
the
feature/button-component-additional
branch
from
August 12, 2024 21:06
df56f7f
to
f3cc983
Compare
hamo-o
force-pushed
the
feature/button-component-additional
branch
from
August 13, 2024 08:45
f3cc983
to
936c0e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
와우클래스에 필요한 버튼 컴포넌트 추가 스펙을 구현했습니다.
🚩 관련 이슈
🙏 여기는 꼭 봐주세요!