Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] LinkButton 사용할 수 있도록 as prop의 네이밍 변경 #146

Merged
merged 8 commits into from
Aug 23, 2024
Merged

[Fix] LinkButton 사용할 수 있도록 as prop의 네이밍 변경 #146

merged 8 commits into from
Aug 23, 2024

Conversation

hamo-o
Copy link
Member

@hamo-o hamo-o commented Aug 21, 2024 •
edited
Loading

🎉 변경 사항

image

이전에는 next/link의 Link를 as로 넘겨주면 위와 같은 에러가 나타났습니다. 저는 타입 에러라고 생각해서 한참을 삽질했는데요..
허무하게도 Link 자체에 as 라는 동일한 prop이 있어 발생한 문제였습니다.

image

컴포넌트 종류를 받을 수 있는 prop 이름을 변경하여 해당 문제를 해결했습니다.

🚩 관련 이슈

🙏 여기는 꼭 봐주세요!

  • Chip 컴포넌트에서도 쓰이는 타입이라 함께 수정된 점 참고 부탁드립니다!
  • 온보딩에서 디자인시스템 버전업할때 주의해주세요!

@hamo-o hamo-o self-assigned this Aug 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-rowbkydrua.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-aekmkimfvq.chromatic.com/

@ghdtjgus76
Copy link
Collaborator

TextButton, TextButton 스토리 문서화, Button 스토리 문서화 부분에도 반영해야 할 거 같습니다~!

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-dxkazgkcad.chromatic.com/

ghdtjgus76
ghdtjgus76 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요!

packages/wow-ui/src/components/Button/Button.stories.tsx Outdated Show resolved Hide resolved
SeieunYoo
SeieunYoo approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@SeieunYoo SeieunYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨어요!! changeset 도 작성해주시면 배포될 거 같습니다~

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-votmhpufgk.chromatic.com/

@hamo-o hamo-o mentioned this pull request Aug 22, 2024
Merged
@hamo-o
Merge pull request #149 from GDSC-Hongik/fix/button-component-pressed
a5de638 
[Fix] aria-pressed 속성 active 대체 및 useButton 훅 삭제
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-ctljkyrawr.chromatic.com/

@hamo-o hamo-o merged commit 3330386 into main Aug 23, 2024
3 checks passed
@hamo-o hamo-o deleted the fix/as-prop branch August 23, 2024 08:38
hamo-o added a commit that referenced this pull request Aug 26, 2024
@hamo-o
[Fix] LinkButton 사용할 수 있도록 as prop의 네이밍 변경 (#146)
3cc30fc 
* fix: as -> asProp 이름 변경

* fix: Chip 테스트코드 prop 변경

* fix: Button, TextButton as prop 쓰인 부분 수정

* fix: LinkButton 스토리북 prop 이름 변경

* chore: changeset 추가

* fix: pressed 속성 active 속성으로 변경

* remove: useButton 훅 삭제
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeieunYoo SeieunYoo SeieunYoo approved these changes

@ghdtjgus76 ghdtjgus76 ghdtjgus76 approved these changes

@eugene028 eugene028 Awaiting requested review from eugene028 eugene028 is a code owner

Assignees

@hamo-o hamo-o

Labels
👩‍💻 리뷰 남겨주세요!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamo-o @ghdtjgus76 @SeieunYoo