Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] DropDownOption id 유니크한 값으로 변경 #148

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

hamo-o
Copy link
Member

@hamo-o hamo-o commented Aug 22, 2024

🎉 변경 사항

  • dropdownId context 추가
  • dropdownId를 이용해서 DropDownOptionid 유니크한 값으로 변경

🚩 관련 이슈

🙏 여기는 꼭 봐주세요!

@hamo-o hamo-o linked an issue Aug 22, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Copy link
Contributor

Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

이것도 changeset 작성해주시면 좋을 거 같아요!

@hamo-o hamo-o merged commit e2586d3 into main Aug 26, 2024
3 checks passed
@hamo-o hamo-o deleted the fix/dropdown-option-id branch August 26, 2024 19:08
hamo-o added a commit that referenced this pull request Aug 26, 2024
* fix: dropdownId context로 전달, option에도 유니크하게 적용

* fix: dropdownId useDropDownState에서 삭제, 따로 넘겨주기
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] DropDown Option의 id 중복
4 participants