[Fix] : Table 컴포넌트의 상위 context가 존재하지 않아도 useContext 에러가 발생하지 않도록 수정해요. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene028
requested review from
ghdtjgus76,
hamo-o and
SeieunYoo
as code owners
🦋 Changeset detectedLatest commit: b797e09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
Table 컴포넌트에서
useSafeContext훅을 사용하고 있었는데, 상위 컨텍스트가 존재하지 않으면 Error를 throw하는 로직을 갖고 있었어요.Table 컴포넌트는
checkbox로직을 사용하지 않으면 context를 사용하지 않을 수도 있어요..!!이를 보완하기 위하여
useSafeContext를 사용하는 대신,context가 null 일때, 기본 객체 값을 리턴할 수 있도록 하여Context를 사용하던 사용하지 않던 에러가 발생하지 않도록 했어요.
🚩 관련 이슈
#173
🙏 여기는 꼭 봐주세요!
@hamo-o
이제 와우 클래스에서 불필요하게 Table 컨텍스트로 감쌌던 로직을 제거해도 문제가 생기지 않을 거예요.