[Feat] 파운데이션, 컴포넌트, 그래픽 페이지 마크업 #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeieunYoo
requested review from
ghdtjgus76,
eugene028 and
hamo-o
as code owners
|
|
Size Change: 0 B Total Size: 680 kB ℹ️ View Unchanged
|
hamo-o
approved these changes
Dec 16, 2024
Comment on lines
+84
to
+88
| const containerStyle = css({ | ||
| backgroundColor: "backgroundAlternative", | ||
| borderRadius: "sm", | ||
| padding: "32px 40px", | ||
| }); |
There was a problem hiding this comment.
p5;
단순한 스타일이긴 하지만,, 엄청나게 반복될 것이 예상되어 요것도 컴포넌트로 따로 빼면 어떨까 합니다! (내용물 children으로 받는 형식)
There was a problem hiding this comment.
좋아요!! Card 라는 컴포넌트로 분리했습니다 e36f808
- scroll bar 추가 - 사이드바에 border 추가
eugene028
reviewed
Dec 17, 2024
| import Link from "next/link"; | ||
|
|
||
| export const metadata: Metadata = { | ||
| title: "컴포넌트", |
There was a problem hiding this comment.
P3;
한글로 직역해서 '컴포넌트' / '파운데이션'이렇게 적으면 조금 어색해보이기도 하고, 코드 관련된 것은 영어로 검색하는 경우가 많으니
영어로 Component <- 요렇게 적는게 더 좋을 것 같기도 해요!
Comment on lines
52
to
56
| <styled.main | ||
| height="100vh" | ||
| left="180px" | ||
| padding="70px 102px 0 101px" | ||
| position="relative" |
There was a problem hiding this comment.
P2;
position이 relative이기 때문에 left 속성이 안먹는 것 같아용!
지금 main 태그 안에 존재하는 레이아웃 스타일이 조금 틀어져서 전반적으로 가운데 정렬이 안맞는 것 같은데,
아래와 같이 스타일 바꿔보면 조금 더 좋아질 것 같아요.
Suggested change
| <styled.main | |
| height="100vh" | |
| left="180px" | |
| padding="70px 102px 0 101px" | |
| position="relative" | |
| <styled.main | |
| height="100vh" | |
| padding="70px 102px 0 101px" | |
| position="relative" | |
| width="100%" | |
| margin-left="250px" | |
| > |
Comment on lines
+27
to
+32
| <div className={headerStyle}> | ||
| <Link href={routePath.overview}> | ||
| <GdscLogo /> | ||
| </Link> | ||
| <div className={titleTextStyle}>Wow Design System</div> | ||
| </div> |
There was a problem hiding this comment.
P3;
GDSC Logo와 와우 디자인 시스템 타이틀 간격이 좁은 것 같아서 조금 조정해주시면 좋을 거같아요!
There was a problem hiding this comment.
P4;
data보다는 조금 더 명시적인 파일 이름을 사용하면 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
🚩 관련 이슈
🙏 여기는 꼭 봐주세요!
와우 디자인 시스템affix 가 붙게끔 생성했습니다.다른 형식이 좋으시면 말씀주세요~