[Feature] Radius, Stroke, Spacing Token 생성 및 theme 패키지 등록 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene028
requested review from
ghdtjgus76,
hamo-o,
SeieunYoo and
kongnayeon
as code owners
eugene028
commented
May 23, 2024
packages/theme/src/index.ts
Outdated
There was a problem hiding this comment.
@SeieunYoo 님이 기존에 color.ts에서 tokens를 export하던 방식을 변경하여 index.ts에서 export하도록 변경하였어요~
eugene028
commented
May 23, 2024
There was a problem hiding this comment.
@ghdtjgus76 docs패키지에서 이렇게 styled-system이 git에 올라가는게 맞을까요 ?? diff가 너무 커지는 것 같아서.. 🥹
There was a problem hiding this comment.
아래 링크 확인 부탁드려요!
#22 (comment)
There was a problem hiding this comment.
요거 옛날부터이 이야기했던 이슈같은데 같이 함 해결해보시죵
|
Component variable 에 맞게 토큰만 수정해주면 머지해도 좋을 것 같습니당 🙌 |
SeieunYoo
reviewed
May 28, 2024
ghdtjgus76
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
Figma에 정의된 세 개의 global Token을 등록했습니다.
또한, panda.config.ts에서 바로 사용할 수 있도록
defineToken을 이용하여 기존 토큰에 덮어씌웠습니다.🚩 관련 이슈
#21
🙏 여기는 꼭 봐주세요!
rem단위를 사용하였습니다.px단위를 사용하였습니다.네이밍과
px,rem의 사용처 같은 경우, 금주 일요일에 진행될 회의에서 예영님과 더욱 자세히 이야기 나누어볼 예정입니다. 대화 이후 네이밍 컨벤션이 변경될 가능성이 큰 상황입니다! 만약 네이밍 컨벤션이 변경된다면 기존에 작업하신 내용을 컨벤션에 맞게 수정하여 PR 추후 따로 나누어 업로드하겠습니다.🔗 관련 슬랙 스레드