[Feature] TextField 컴포넌트 구현 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghdtjgus76
requested review from
eugene028,
hamo-o,
SeieunYoo and
kongnayeon
as code owners
|
흠 요것도 color contrast 때문에 a11y test 통과 못하는 듯 하네요 ㅠ |
예영님께 여쭤봤는데, disabled / placeholder 관련해서는 일부러 색을 연하게 작업하신거라고 해서 별도로 색을 변경하지 않기로 했어요! |
eugene028
reviewed
Jun 8, 2024
eugene028
reviewed
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
TextField 컴포넌트 구현했습니다.
sub, success, error 토큰 색상이 변경되었고, 반응형 관련 breakpoint도 같이 추가해놨습니다.
🚩 관련 이슈
🙏 여기는 꼭 봐주세요!
Switch 컴포넌트 리팩토링이랑 SwitchGroup 컴포넌트 수정은 Checkbox 컴포넌트 머지된 후에 얼른 하겠습니다!