Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] : Checkbox 컴포넌트 pressed, cursor 관련 수정 #47

Merged
merged 2 commits into from
Jun 10, 2024
Merged

[Fix] : Checkbox 컴포넌트 pressed, cursor 관련 수정 #47

merged 2 commits into from
Jun 10, 2024

Conversation

SeieunYoo
Copy link
Collaborator

🎉 변경 사항

스토리북 살펴보다가 체크박스 수정해야될 부분이 있어 호다닥 수정해봅니당..

  • pressed 상태일 때에만 data-pressed 값을 가지도록 수정합니다.
  • input의 type 이 checkbox 일 때 무조건 cursor:default 가 들어가서 cursor: inherit 을 통해 label 에서 정한 cursor css 를 받을 수 있도록 수정합니다.

🚩 관련 이슈

🙏 여기는 꼭 봐주세요!

@SeieunYoo SeieunYoo self-assigned this Jun 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-qawpvmgqee.chromatic.com/

ghdtjgus76
ghdtjgus76 approved these changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿

hamo-o
hamo-o approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@hamo-o hamo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어용 🚀

@SeieunYoo SeieunYoo merged commit df5a7e9 into main Jun 10, 2024
3 checks passed
@SeieunYoo SeieunYoo deleted the fix/check-box-component branch June 10, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamo-o hamo-o hamo-o approved these changes

@ghdtjgus76 ghdtjgus76 ghdtjgus76 approved these changes

@eugene028 eugene028 Awaiting requested review from eugene028 eugene028 is a code owner

@kongnayeon kongnayeon Awaiting requested review from kongnayeon

Assignees

@SeieunYoo SeieunYoo

Labels
👩‍💻 리뷰 남겨주세요!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeieunYoo @ghdtjgus76 @hamo-o