-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] 스토리 코드 생성 자동화 #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamo-o
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨어요!! 스토리북 작성이 편해지겠네요 👍
SeieunYoo
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고 많으셨습니다 🤗
@hamo-o @SeieunYoo 리뷰 다 반영해뒀습니다~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
스토리 코드 생성 자동화 기능 도입했습니다.
plop을 이용해 codegen/templates/Story.tsx.hbs 템플릿 파일 기반으로 작동하도록 했습니다.
wow-ui 쪽에 create:story-file이라는 스크립트를 추가했는데, codegen에서 plop을 실행해서 스토리 코드를 작성하게 합니다.
아래와 같이 wow-ui에서 create:story-file 스크립트를 실행시키면 됩니다.
템플릿에 주석을 달아뒀으니 스토리 코드 다 작성하시고 지워주시면 됩니다.
그리고 기존 스토리북 문서들에서 자잘한 부분도 같이 수정해놨습니다.
🚩 관련 이슈
🙏 여기는 꼭 봐주세요!