Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Checkbox 컴포넌트의 children label prop으로 수정, ReactNode 타입으로 수정 #66

Merged
merged 3 commits into from
Jun 30, 2024
Merged

[Fix] Checkbox 컴포넌트의 children label prop으로 수정, ReactNode 타입으로 수정 #66

merged 3 commits into from
Jun 30, 2024

Conversation

SeieunYoo
Copy link
Collaborator

🎉 변경 사항

  • Checkbox 컴포넌트에서 children prop 을 label prop 으로 수정합니다.
  • label 관련 타입을 ReactNode 로 수정합니다.

🚩 관련 이슈

🙏 여기는 꼭 봐주세요!

@SeieunYoo SeieunYoo self-assigned this Jun 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-sazpwdigrk.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-iyqvjxbbhy.chromatic.com/

ghdtjgus76
ghdtjgus76 approved these changes Jun 29, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 수고하셨습니다!

eugene028
eugene028 approved these changes Jun 30, 2024
View reviewed changes
Copy link
Collaborator

@eugene028 eugene028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@SeieunYoo SeieunYoo merged commit 1728b3f into main Jun 30, 2024
3 checks passed
@SeieunYoo SeieunYoo deleted the fix/checkbox-children branch June 30, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghdtjgus76 ghdtjgus76 ghdtjgus76 approved these changes

@eugene028 eugene028 eugene028 approved these changes

@hamo-o hamo-o Awaiting requested review from hamo-o hamo-o is a code owner

@kongnayeon kongnayeon Awaiting requested review from kongnayeon

Assignees

@SeieunYoo SeieunYoo

Labels
👩‍💻 리뷰 남겨주세요!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeieunYoo @eugene028 @ghdtjgus76