Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rub_the_lamp.sh #13

Merged
merged 1 commit into from
Nov 5, 2015
Merged

Conversation

mnirkko
Copy link
Contributor

@mnirkko mnirkko commented Nov 5, 2015

Correct minor typos.

Correct minor typos.
@gnperdue
Copy link
Member

gnperdue commented Nov 5, 2015

Haha, nice catches.

gnperdue added a commit that referenced this pull request Nov 5, 2015
@gnperdue gnperdue merged commit 9cc5a51 into GENIE-MC-Community:master Nov 5, 2015
@mnirkko
Copy link
Contributor Author

mnirkko commented Nov 5, 2015

Thanks. I'm wary of this stuff since I have to modify the script
slightly to use our pre-built versions of ROOT, GSL and PYTHIA.
Did you do any relevant changes to build_support.sh? Haven't diff'ed
that one yet. :)

On 05.11.2015 20:27, Gabriel Perdue wrote:

Haha, nice catches.


Reply to this email directly or view it on GitHub
#13 (comment).

@gnperdue
Copy link
Member

gnperdue commented Nov 5, 2015

Don't think I changed much of anything in the support package.

A to-do item for me for a long time has been letting users pass in the location of various 3rd party libs instead of automatically installing them.

#2 #2

If you're hacking that sort of functionality in anyway, maybe submit a pull request? ^_^

Otherwise, I'll get to it someday...

pax
Gabe

On Nov 5, 2015, at 1:43 PM, Martti Nirkko [email protected] wrote:

Thanks. I'm wary of this stuff since I have to modify the script
slightly to use our pre-built versions of ROOT, GSL and PYTHIA.
Did you do any relevant changes to build_support.sh? Haven't diff'ed
that one yet. :)

On 05.11.2015 20:27, Gabriel Perdue wrote:

Haha, nice catches.


Reply to this email directly or view it on GitHub
#13 (comment).


Reply to this email directly or view it on GitHub #13 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants