Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/#127 #130

Merged
merged 6 commits into from
Aug 10, 2023
Merged

Refactor/#127 #130

merged 6 commits into from
Aug 10, 2023

Conversation

seunghaLim
Copy link
Collaborator

@seunghaLim seunghaLim commented Aug 9, 2023 •
edited
Loading

๐Ÿž PR ํƒ€์ž…

  • ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๊ธฐ๋Šฅ ์ˆ˜์ •
  • ๊ธฐ๋Šฅ ์‚ญ์ œ
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ์˜์กด์„ฑ, ํ™˜๊ฒฝ ๋ณ€์ˆ˜, ๋นŒ๋“œ ๊ด€๋ จ ์ฝ”๋“œ ์—…๋ฐ์ดํŠธ

๐Ÿž ๋ฐ˜์˜ ๋ธŒ๋žœ์น˜

refactor/#127 -> dev

๐Ÿž ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • ๋ฐ•์‹ฑํƒ€์ž…์œผ๋กœ ์„ ์–ธํ•œ ํ•„๋“œ๋ฅผ ๊ธฐ๋ณธํƒ€์ž…์œผ๋กœ ๋ณ€๊ฒฝ
  • ๊ตฌ๊ธ€ ์ž๋ฐ” ํฌ๋งทํ„ฐ ์‚ฌ์šฉ
  • ๋งคํผ ์ ์šฉํ•ด์„œ entity -> dto ๋ณ€๊ฒฝ

๐Ÿž ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ

๐Ÿž To Reviewer

sung-silver
sung-silver approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@sung-silver sung-silver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ธฐ๋ณธ ํƒ€์ž…์œผ๋กœ ๋ฐ”๊พธ๋Š”๊ฑฐ ์ข‹์Šต๋‹ˆ๋‹ค!! ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค :)

@seunghaLim seunghaLim merged commit 4b0227e into dev Aug 10, 2023
@sung-silver sung-silver removed their assignment Aug 12, 2023
@seunghaLim seunghaLim deleted the refactor/#127 branch August 14, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sung-silver sung-silver sung-silver approved these changes

Assignees
No one assigned
Labels
FIX seungha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seunghaLim @sung-silver