Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

베스트 빵집 및 베스트 리뷰 조회 시 버그 발생 해결 #299

Merged
merged 2 commits into from
Feb 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/src/main/java/com/org/gunbbang/service/BakeryService.java
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,9 @@ private List<Bakery> getOnlyRandomBakeries() {
private boolean isFilterSelected(Member foundMember) {
boolean isBreadTypeSelected = memberBreadTypeRepository.existsByMember(foundMember);
boolean isNutrientTypeSelected = memberNutrientTypeRepository.existsByMember(foundMember);
boolean isMainPurposeNone = foundMember.getMainPurpose().equals(MainPurpose.NONE);
boolean isMainPurposeSelected = !foundMember.getMainPurpose().equals(MainPurpose.NONE);

return isBreadTypeSelected && isNutrientTypeSelected && isMainPurposeNone;
return isBreadTypeSelected && isNutrientTypeSelected && isMainPurposeSelected;
}

private void setAlreadyFoundBakeryIds(
Expand Down
8 changes: 4 additions & 4 deletions api/src/main/java/com/org/gunbbang/service/ReviewService.java
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public class ReviewService {
private final MemberRepository memberRepository;
private final RecommendKeywordRepository recommendKeywordRepository;
private final MemberBreadTypeRepository memberBreadTypeRepository;
private final MemberBreadTypeRepository memberNutrientTypeRepository;
private final MemberNutrientTypeRepository memberNutrientTypeRepository;
private final BakeryBreadTypeRepository bakeryBreadTypeRepository;
private final int MAX_BEST_BAKERY_COUNT = 10;

Expand Down Expand Up @@ -256,9 +256,9 @@ private List<Review> getRandomReviews() {
private boolean isFilterSelected(Member foundMember) {
boolean isBreadTypeSelected = memberBreadTypeRepository.existsByMember(foundMember);
boolean isNutrientTypeSelected = memberNutrientTypeRepository.existsByMember(foundMember);
boolean isMainPurposeNone = foundMember.getMainPurpose().equals(MainPurpose.NONE);
boolean isMainPurposeSelected = !foundMember.getMainPurpose().equals(MainPurpose.NONE);

return isBreadTypeSelected && isNutrientTypeSelected && isMainPurposeNone;
return isBreadTypeSelected && isNutrientTypeSelected && isMainPurposeSelected;
}

private void getRestReviewsRandomly(
Expand All @@ -280,7 +280,7 @@ private List<BestReviewDTO> getBestReviews(Member foundMember, List<BreadType> b
PageRequest bestPageRequest = PageRequest.of(0, MAX_BEST_BAKERY_COUNT);
List<BestReviewDTO> bestReviews =
reviewRepository.findBestReviewDTOList(
breadTypes, foundMember.getMainPurpose(), bestPageRequest);
breadTypes, foundMember.getMainPurpose()); // , bestPageRequest);
return bestReviews;
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
package com.org.gunbbang.entity;

import javax.persistence.*;
import lombok.AccessLevel;
import lombok.Getter;
import lombok.NoArgsConstructor;

@Entity
@Getter
Expand All @@ -12,6 +14,7 @@
name = "BAKERY_ID_BREAD_TYPE_ID_UNIQUE",
columnNames = {"bakery_id", "bread_type_id"})
})
@NoArgsConstructor(access = AccessLevel.PROTECTED)
public class BakeryBreadType {
@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,20 @@
package com.org.gunbbang.entity;

import javax.persistence.*;
import lombok.AccessLevel;
import lombok.Getter;
import lombok.NoArgsConstructor;

@Entity
@Getter
@Table(
name = "bakeryNutrientType",
uniqueConstraints = {
@UniqueConstraint(
name = "BAKERY_ID_NUTRIENT_TYPE_ID_UNIQUE",
columnNames = {"bakery_id", "nutrient_type_id"})
})
@NoArgsConstructor(access = AccessLevel.PROTECTED)
public class BakeryNutrientType {
@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,6 @@ public interface BookMarkRepository extends JpaRepository<BookMark, Long> {

@Query(value = "SELECT bm FROM BookMark bm WHERE bm.member.memberId = :memberId")
List<BookMark> findAllByMemberId(Long memberId);

List<BookMark> findAllByBakery(Bakery bakery);
}
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,17 @@ public interface ReviewRepository extends JpaRepository<Review, Long> {
+ "r.createdAt) FROM Review r "
+ "INNER JOIN Bakery b ON b.bakeryId = r.bakery.bakeryId "
+ "INNER JOIN Member m ON r.member.memberId = m.memberId "
+ "INNER JOIN MemberBreadType mbt ON r.member.memberId = mbt.member.memberId "
+ "INNER JOIN MemberBreadType mbt ON m.memberId = mbt.member.memberId "
+ "WHERE mbt.breadType in :currentMemberBreadType "
+ "AND r.isLike = true "
+ "AND r.member.mainPurpose = :currentMemberMainPurpose "
+ "AND r.reviewText IS NOT NULL AND r.reviewText != '' "
+ "ORDER BY r.createdAt desc")
List<BestReviewDTO> findBestReviewDTOList(
@Param("currentMemberBreadType") List<BreadType> currentMemberBreadType,
@Param("currentMemberMainPurpose") MainPurpose mainPurpose,
PageRequest bestPageRequest);
@Param("currentMemberMainPurpose") MainPurpose mainPurpose);

// PageRequest bestPageRequest);

@Query(
value =
Expand Down
Loading