Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] 주석 처리한 페이지네이션 부분 해제 #306

Merged
merged 1 commit into from
Mar 1, 2024
Merged

[HOTFIX] 주석 처리한 페이지네이션 부분 해제 #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions api/src/main/java/com/org/gunbbang/service/BakeryService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,9 +267,6 @@ private void getRestBakeries(
private List<Bakery> getBestBakeries(Member foundMember, List<BreadType> breadTypes) {
log.info("########## 베스트 건빵집 조회 시작 ##########");
PageRequest bestPageRequest = PageRequest.of(0, MAX_BEST_BAKERY_COUNT);

// 1. MemberBreadType 뒤져서 나랑 동일한 BreadType 선택한 멤버 가져옴
// 2. 북마크 테이블+베이커리 테이블 뒤져서 해당 멤버들이 북마크한 빵집 가져옴
List<Bakery> bestBakeries =
bakeryRepository.findBestBakeries(
breadTypes, foundMember.getMainPurpose(), bestPageRequest);
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/com/org/gunbbang/service/ReviewService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ private List<BestReviewDTO> getBestReviews(Member foundMember, List<BreadType> b
PageRequest bestPageRequest = PageRequest.of(0, MAX_BEST_BAKERY_COUNT);
List<BestReviewDTO> bestReviews =
reviewRepository.findBestReviewDTOList(
breadTypes, foundMember.getMainPurpose()); // , bestPageRequest);
breadTypes, foundMember.getMainPurpose(), bestPageRequest);
return bestReviews;
}

Expand Down
5 changes: 2 additions & 3 deletions storage/db-core/src/main/java/com/org/gunbbang/repository/ReviewRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,8 @@ public interface ReviewRepository extends JpaRepository<Review, Long> {
+ "ORDER BY r.createdAt desc")
List<BestReviewDTO> findBestReviewDTOList(
@Param("currentMemberBreadType") List<BreadType> currentMemberBreadType,
@Param("currentMemberMainPurpose") MainPurpose mainPurpose);

// PageRequest bestPageRequest);
@Param("currentMemberMainPurpose") MainPurpose mainPurpose,
PageRequest bestPageRequest);

@Query(
value =
Expand Down
Loading