Merge pull request #249 from GEON-PPANG/hotfix/#248

[Hotfix] #248 - 하하 릴리즈하자마자 버그 발견 ^___^ 을 해결하기 위한 이슈
GEON-PPANG · Mar 28, 2024 · 4825351 · 4825351
2 parents 2ea76dc + ba219f6
commit 4825351
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 8 deletions.
diff --git a/GEON-PPANG-iOS/Presentation/BakeryDetail/Cell/InfoCollectionViewCell.swift b/GEON-PPANG-iOS/Presentation/BakeryDetail/Cell/InfoCollectionViewCell.swift
@@ -96,11 +96,12 @@ final class InfoCollectionViewCell: UICollectionViewCell {
         openingHoursSection.addSubview(closedDaysLabel)
         closedDaysLabel.snp.makeConstraints {
             $0.leading.equalTo(openingHoursImage.snp.trailing).offset(10)
+            $0.trailing.equalToSuperview()
             $0.top.equalToSuperview()
         }
         openingHoursSection.addSubview(openingHoursLabel)
         openingHoursLabel.snp.makeConstraints {
-            $0.leading.equalTo(closedDaysLabel)
+            $0.horizontalEdges.equalTo(closedDaysLabel)
             $0.top.equalTo(closedDaysLabel.snp.bottom).offset(2)
             $0.bottom.equalToSuperview()
         }
@@ -188,6 +189,7 @@ final class InfoCollectionViewCell: UICollectionViewCell {
         if data.homepageURL == "" && data.instagramURL == "" {
             linkSection.isHidden = true
         } else {
+            linkSection.isHidden = false
             linkButtonStackView.getLinkStatus(data.homepageURL, data.instagramURL)
         }
         addressLabel.text = data.address

diff --git a/GEON-PPANG-iOS/Presentation/BakeryDetail/ViewControllers/BakeryDetailViewController.swift b/GEON-PPANG-iOS/Presentation/BakeryDetail/ViewControllers/BakeryDetailViewController.swift
@@ -52,12 +52,18 @@ final class BakeryDetailViewController: BaseViewController {
 
     // MARK: - Life Cycle
 
+    override func viewDidLoad() {
+        super.viewDidLoad()
+
+        guard let bakeryID = self.bakeryID else { return }
+        getBakeryDetail(bakeryID: bakeryID)
+    }
+
     override func viewWillAppear(_ animated: Bool) {
         super.viewWillAppear(animated)
 
         guard let bakeryID = self.bakeryID else { return }
-
-        getBakeryDetail(bakeryID: bakeryID, isUpdated: true)
+        getWrittenReviews(bakeryID: bakeryID, isUpdated: true)
 
         navigationController?.interactivePopGestureRecognizer?.delegate = nil // swipe back gesture
     }
@@ -414,7 +420,7 @@ extension BakeryDetailViewController: UICollectionViewDelegateFlowLayout {
 
 extension BakeryDetailViewController {
 
-    func getBakeryDetail(bakeryID: Int, isUpdated: Bool) {
+    func getBakeryDetail(bakeryID: Int) {
 
         BakeriesAPI.shared.getBakeryDetail(bakeryID: bakeryID) { response in
 
@@ -427,7 +433,6 @@ extension BakeryDetailViewController {
             self.detailBottomView.configureBookmarkButton(to: data.isBookMarked)
             self.homepageURL = data.homepageURL
             self.instagramURL = data.instagramURL
-            self.getWrittenReviews(bakeryID: bakeryID, isUpdated: isUpdated)
         }
     }
 
@@ -455,7 +460,7 @@ extension BakeryDetailViewController {
             AnalyticManager.log(event: .detail(.clickMystore))
             self.detailBottomView.configureBookmarkButton(to: value)
             self.isBookmarked = value
-            self.getBakeryDetail(bakeryID: bakeryID, isUpdated: false)
+            self.getBakeryDetail(bakeryID: bakeryID)
         }
     }
 

diff --git a/GEON-PPANG-iOS/Presentation/Search/Cell/EmptyCollectionViewCell.swift b/GEON-PPANG-iOS/Presentation/Search/Cell/EmptyCollectionViewCell.swift
@@ -97,7 +97,6 @@ final class EmptyCollectionViewCell: UICollectionViewCell {
         emptyLabel.do {
             $0.numberOfLines = 0
             $0.basic(font: .title2!, color: .gbbGray300!, align: .center)
-            $0.textAlignment = .center
         }
     }
 
@@ -117,7 +116,8 @@ final class EmptyCollectionViewCell: UICollectionViewCell {
         case .initialize, .noReview, .noMyReview, .noBookmark:
             return emptyLabel.basic(text: emptyType.rawValue,
                                     font: .title2!,
-                                    color: .gbbGray300!)
+                                    color: .gbbGray300!,
+                                    align: .center)
         case .noSearch:
             return emptyLabel.partFontChange(targetString: type.subTitle, font: .subHead!)
         }