Add Group & Wrapper source XML line in errors #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added SourceContext to know where Groups/Wrappers has been declared - Added a test for the node & attribute line infos
MelReyCG
changed the title
9 tasks
…y/2320-xml-errors-feedback" - using getSourceContext() instead of getPath()
…ack-3' into feature/rey/error-xml-line-2-errors-impacting
untereiner
approved these changes
Apr 21, 2023
- also renaming FileContext to DataFileContext
- code refactoring + doc edit
TotoGaz
reviewed
Aug 8, 2023
(used string_view to support raw string loading)
…S-DEV/GEOS into feature/rey/error-xml-line-2
|
Do you think we've addressed all the comments and that this should be merged? |
|
@TotoGaz Can you have a look on this one? #2404 (comment) (I can keep my initial proposal but I don't know if you are ok with it). |
klevzoff
reviewed
Aug 24, 2023
klevzoff
reviewed
Aug 25, 2023
|
@MelReyCG I've put the PR in the merge queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to:
Group&Wrapperin order to know from where they have been declared. When possible, this will allow to know in which source file and where exactly they have been defined (file line, offset), if not it will fallback to the Group hierarchy.This metadata will allow us to formulate error messages that can be clearer and faster to solve for users ( issue [EPIC] Improve feedback to user on XML errors #2320 ).
This PR propose to put this metadata in a
SourceContextabstract object, so if theGroups&Wrappersare loaded differently, we will be able to change the attached information.To impact the modifications on most GEOS files, 4 PR have been created to process multiple batches of files separately :
I planned to add another PR where I'll propose to properly wrap the following
xmlWrappertypes:xmlNode,xmlAttribute, xmlType