Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement EDFM loading from VTK #3082

Closed
wants to merge 50 commits into from

Conversation

ouassimkh
Copy link

@ouassimkh ouassimkh commented Apr 16, 2024

Implement EDFM loading and tested it on a simple 2.5D EDFM case. Below is an input example containing 2 fracture elements:

  • fracture_ids_points: represent all the fracture patch point ids including shared points (no duplicates).
  • fracture_to_paren_matrix_cell_mapping: maps each edfm fracture element to matrix element.
  • permeability : fracture elements permeability (loaded but not used yet, we continue to use constant fracture props provided with CompressibleSolidParallelPlatesPermeability)
  • aperture: is fracture aperture
  • tangential_width_vectors, tangential_length_vectors and normal_vectors are the 3 principal vectors of a fracture patch plan.
  • connectivity: each patch is represented by a 4 points (quad).

image

<?xml version="1.0"?>
<VTKFile type="UnstructuredGrid" version="0.1" byte_order="LittleEndian" header_type="UInt32" compressor="vtkZLibDataCompressor">
  <UnstructuredGrid>
    <Piece NumberOfPoints="6" NumberOfCells="2">
      <PointData>
        <DataArray type="Int32" Name="fracture_ids_points" NumberOfComponents="1" format="ascii">
         0
         1
         2
         3
         4
         5
        </DataArray>
      </PointData>
      <CellData>
        <DataArray type="Int32" Name="fracture_to_parent_matrix_cell_mapping" NumberOfComponents="2" format="ascii">
         0 4
         1 13
        </DataArray>
        <DataArray type="Float32" Name="permeability" NumberOfComponents="1" format="ascii" RangeMin="0.1" RangeMax="0.1">
          0.1
          0.1
        </DataArray>
        <DataArray type="Float32" Name="aperture" NumberOfComponents="1" format="ascii" RangeMin="0.0001" RangeMax="0.0001">
          0.0001
          0.0001
        </DataArray>
        <DataArray type="Float32" Name="tangential_width_vectors" NumberOfComponents="3" format="ascii">
          0 0 1
          0 0 1
        </DataArray>
        <DataArray type="Float32" Name="tangential_length_vectors" NumberOfComponents="3" format="ascii">
          0 1 0
          0 1 0
        </DataArray>
        <DataArray type="Float32" Name="normal_vectors" NumberOfComponents="3" format="ascii">
          1 0 0
          1 0 0
        </DataArray>
      </CellData>
      <Points>
        <DataArray type="Float32" Name="Points" NumberOfComponents="3" format="ascii" RangeMin="0" RangeMax="1">
          0.5 0.3333 0
          0.5 0.6666 0
          0.5 0.3333 0.5
          0.5 0.6666 0.5
          0.5 0.3333 1
          0.5 0.6666 1
          <InformationKey name="L2_NORM_RANGE" location="vtkDataArray" length="2">
            <Value index="0">
              0
            </Value>
            <Value index="1">
              1
            </Value>
          </InformationKey>
        </DataArray>
      </Points>
      <Cells>
        <DataArray type="Int64" Name="connectivity" format="ascii" RangeMin="0" RangeMax="5">
        1 0 2 3
        3 2 4 5
        </DataArray>
        <DataArray type="Int64" Name="offsets" format="ascii" RangeMin="4" RangeMax="8">
          4
          8
        </DataArray>
        <DataArray type="UInt8" Name="types" format="ascii" RangeMin="9" RangeMax="9">
          9
          9
        </DataArray>
      </Cells>
    </Piece>
  </UnstructuredGrid>
</VTKFile>

@ouassimkh ouassimkh requested review from TotoGaz and CusiniM April 16, 2024 15:04
@TotoGaz TotoGaz removed their request for review July 5, 2024 17:08
@ouassimkh ouassimkh force-pushed the Feature/ouassim/edfm_loader_new branch from 8dc1a32 to 041d290 Compare October 21, 2024 14:34
@ouassimkh ouassimkh changed the title Feature/ouassim/edfm loader new [Feat] Implement 2.5D EDFM loading from VTK (serial only) Oct 21, 2024
@ouassimkh ouassimkh changed the title [Feat] Implement 2.5D EDFM loading from VTK (serial only) feat: Implement 2.5D EDFM loading from VTK (serial only) Oct 21, 2024
@MelReyCG MelReyCG closed this Dec 16, 2024
@MelReyCG MelReyCG deleted the Feature/ouassim/edfm_loader_new branch December 16, 2024 14:22
@ouassimkh ouassimkh restored the Feature/ouassim/edfm_loader_new branch December 16, 2024 14:30
@ouassimkh
Copy link
Author

Just wondering why was the branch closed? is it merged ?

@paveltomin paveltomin reopened this Dec 16, 2024
@MelReyCG
Copy link
Contributor

Sorry to have closed it, it was not intended at all!

@MelReyCG
Copy link
Contributor

Hi Pavel,
I just looked at this PR to see what It was about, and I got some issues because of letter case confusion in the branches names on this PR (origin/Feature/... by @ouassimkh and origin/feature/... by @paveltomin if I remember correctly), my goal was to remove the older branch by @ouassimkh.
Sorry for the troubles, closing the PR was not my intention.

@paveltomin paveltomin added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Dec 17, 2024
@paveltomin paveltomin changed the title feat: Implement EDFM loading from VTK (serial only) feat: Implement EDFM loading from VTK Dec 19, 2024
@paveltomin
Copy link
Contributor

i added global to local mappings to fix the parallel run
still needs to be tested for more complex cases
removed "serial only" from the title

@GEOS-DEV GEOS-DEV deleted a comment from ouassimkh Dec 19, 2024
@paveltomin paveltomin closed this Jan 9, 2025
@paveltomin paveltomin deleted the Feature/ouassim/edfm_loader_new branch January 9, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants