-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Configuration loop acceleration for SolidMechanicsLagrangeContact #3349
Open
sohailwaziri
wants to merge
91
commits into
develop
Choose a base branch
from
swaziri/configLoop_acceleration
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 82 commits
Commits
Show all changes
91 commits
Select commit
Hold shift + click to select a range
130bb87
dPerm_dDispJump added to ConstantPermeability model
sohailwaziri 0edfafa
print statements added for debugging
sohailwaziri 0162130
print statements and fix for accumulation term in SinglePhasePoromech…
sohailwaziri f6370c1
modifications to fracture update in Coulomb contact and printing stat…
sohailwaziri 86c00dc
comment print statements
sohailwaziri 1c92ab8
fix a bug in updating m_elasticslip which was updated each newton in …
Guotong-Ren 243c182
more print statements
sohailwaziri fc8e3fc
print statements added to check that previousDispJump is constant ins…
sohailwaziri c27f80e
local aitken acceleration of yield
sohailwaziri 43f89f9
new additions to penalty method for edfm-efem
sohailwaziri 9f635d0
just saving
sohailwaziri d4d5e3d
Added Nicola's mgr strategy for SinglePhasePoromechanicsConformingFra…
sohailwaziri 3aa7ae9
just saving
sohailwaziri 8bb1057
Merge remote-tracking branch 'origin/develop' into swaziri/experimental
e1c39fc
remove debug and clarify merging
be65f14
Update SolidMechanicsLagrangeContact.cpp
paveltomin 766728c
Update SolidMechanicsLagrangeContact.cpp
paveltomin 8924a70
code style
1dc1c13
Merge branch 'swaziri/experimental' of https://github.com/GEOS-DEV/GE…
1ff4c7c
Merge branch 'swaziri/experimental' into swaziri/configLoop_acceleration
7cd3012
remove debug and code style
3de2ded
more clean up
5a4cf02
build fix
66d6019
Update SinglePhaseBase.cpp
paveltomin 3604693
this should do
568cd91
pull out m_plasticSlip and m_slip from updates
515f297
revert what is not necessary
437bd4d
code style
6b73437
Merge branch 'swaziri/experimental' into swaziri/configLoop_acceleration
paveltomin deef4e9
small cleanup
df4f854
refactor a bit
5cb6867
Update SolidMechanicsLagrangeContact.cpp
paveltomin 9d18ae4
Update SolidMechanicsLagrangeContact.cpp
paveltomin 634d987
Update SolidMechanicsLagrangeContact.cpp
paveltomin 5584670
Update SolidMechanicsLagrangeContact.cpp
paveltomin 222e754
Update SolidMechanicsLagrangeContact.cpp
paveltomin 5bbe4a0
Merge branch 'swaziri/experimental' into swaziri/configLoop_acceleration
paveltomin 307ab03
Merge remote-tracking branch 'origin/develop' into swaziri/experimental
a599f70
EDFM bugfixes, part of #3348
29f29d7
Merge branch 'pt/edfm-sohail-bugfix' into swaziri/experimental
paveltomin 4f5753c
Update SinglePhasePoromechanicsEFEM_impl.hpp
paveltomin 4192292
Update SinglePhasePoromechanicsEFEM_impl.hpp
paveltomin c733455
revert
56f641e
Merge branch 'swaziri/experimental' of https://github.com/GEOS-DEV/GE…
280cdd8
Merge remote-tracking branch 'origin/swaziri/experimental' into swazi…
f41e051
fix sign directly in computeLimitTangentialTractionNorm
922951b
code style
1456769
Merge branch 'develop' into pt/edfm-sohail-bugfix
paveltomin 1c28f29
Update CoulombFriction.hpp
paveltomin 37ea618
Merge branch 'pt/edfm-sohail-bugfix' into swaziri/experimental
paveltomin 0bffafb
Merge branch 'develop' into pt/edfm-sohail-bugfix
paveltomin 78a90da
Update .integrated_tests.yaml
paveltomin 4cfc999
Update BASELINE_NOTES.md
paveltomin 63920c7
Merge branch 'develop' into pt/edfm-sohail-bugfix
paveltomin a7736cb
Merge branch 'pt/edfm-sohail-bugfix' into swaziri/experimental
paveltomin 0b3cad5
make that case running
701a258
code style
6cd5f0b
Merge branch 'develop' into pt/edfm-sohail-bugfix
paveltomin 029bd07
make default aperture consistent with table
36a3ed2
Merge branch 'pt/edfm-sohail-bugfix' into swaziri/experimental
paveltomin d35fdf2
Merge branch 'develop' into swaziri/experimental
paveltomin e5bed8c
Merge branch 'develop' into swaziri/experimental
paveltomin 5f9a154
Update ExponentialDecayPermeability_edfm_base.xml
paveltomin 40075dd
Update src/coreComponents/physicsSolvers/contact/SolidMechanicsLagran…
paveltomin 677319c
Merge branch 'develop' into swaziri/experimental
paveltomin 7cf8111
Matteo's comments
08e0c0c
Update SolidMechanicsLagrangeContact.cpp
paveltomin d831ac0
Update SolidMechanicsLagrangeContact.cpp
paveltomin 5d0065a
Update SolidMechanicsLagrangeContact.cpp
paveltomin eba5a61
move elastic slip update to the end of time step
f98207d
Merge branch 'swaziri/experimental' of https://github.com/GEOS-DEV/GE…
9d39b2d
Update CoulombFriction.hpp
paveltomin d2b4de9
one last thing
0fba6ed
Merge branch 'swaziri/experimental' of https://github.com/GEOS-DEV/GE…
6360d92
Update src/coreComponents/physicsSolvers/contact/SolidMechanicsEmbedd…
paveltomin 4458126
Merge branch 'develop' into swaziri/experimental
paveltomin 8f29c5b
Merge branch 'swaziri/experimental' into swaziri/configLoop_acceleration
paveltomin 7354345
minor changes
c169ece
Merge branch 'develop' into swaziri/experimental
paveltomin 0a42e72
bug fix
paveltomin f72951b
Merge branch 'swaziri/experimental' into swaziri/configLoop_acceleration
paveltomin 49ceff0
Merge branch 'develop' into swaziri/configLoop_acceleration
paveltomin f4686d8
Merge branch 'develop' into swaziri/configLoop_acceleration
paveltomin 1a45f32
crash fix
e8f7ac2
Merge branch 'develop' into swaziri/configLoop_acceleration
paveltomin fc85724
Merge branch 'develop' into swaziri/configLoop_acceleration
paveltomin 72be641
Merge branch 'develop' into swaziri/configLoop_acceleration
paveltomin 596dd55
Merge branch 'develop' into swaziri/configLoop_acceleration
paveltomin 61ae1b5
Merge branch 'develop' into swaziri/configLoop_acceleration
paveltomin 861d9d4
Merge branch 'develop' into swaziri/configLoop_acceleration
paveltomin 8d013ca
Merge remote-tracking branch 'origin/develop' into swaziri/configLoop…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the example suggested by @matteofrigo5 (ContactMechanics_SimpleCubes_smoke).
It happens that
total_size
computed ininitializeAccelerationVariables
is equal to 0, hence GEOS crashes here becausem_x0
has zero size, as all the other allocated arrays needed for the nonlinear acceleration.I suspect it is because in that example the
SurfaceGenerator
is used to split the mesh.@sohailwaziri: please make sure
initializeAccelerationVariables
is called after the mesh has been split, when theSurfaceGenerator
is used. Thanks!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i got it fixed by moving
initializeAccelerationVariables
intosetupSystem
without acceleration:
with acceleration:
so acceleration does not hurt but does not help either
maybe some parameter needs to be tuned as Sohail mentioned yesterday