-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Standardisation of incorrect sub-group creation errors #3418
Open
MelReyCG
wants to merge
34
commits into
develop
Choose a base branch
from
bugfix/rey/bad-child-error
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added context to know the erroneous parent & exposed a unique error reference for other classes.
…gionManager define possible child keys
MelReyCG
changed the title
Standardisation of incorrect subgroup creation errors
Standardisation of incorrect sub-group creation errors
Oct 30, 2024
MelReyCG
added
flag: ready for review
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
labels
Nov 7, 2024
MelReyCG
requested review from
rrsettgast,
corbett5,
wrtobin,
CusiniM,
paveltomin,
klevzoff,
francoishamon and
untereiner
as code owners
November 7, 2024 11:21
MelReyCG
requested review from
cssherman,
castelletto1,
andrea-borio,
dkachuma and
joshua-white
as code owners
November 7, 2024 11:21
MelReyCG
changed the title
Standardisation of incorrect sub-group creation errors
fix: Standardisation of incorrect sub-group creation errors
Nov 7, 2024
rrsettgast
approved these changes
Dec 19, 2024
looks like there are some changes from |
@wrtobin half mistake, half in place pratices in |
wrtobin
approved these changes
Jan 6, 2025
paveltomin
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
flag: ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim to standardise the behaviour & log message when user attempt to create in a given node:
Group
type name request inGroup::createChild()
)For instance, before this PR, entering raw text in a
<ElementRegions>
resulted in a misleading message:We would now have:
If a
Group
type would need this kind of sub-content later, we would have to manage this data, and silence this error for the case it would be allowed.For instance, before this PR, adding a wrongly spelled
<Perforation>
, or any unexpected name, in a<InternalWell>
a resulted in:We would now have:
Previously, error of this kind were not always managed properly. Also, various
Group
types messages were not standardized nor indicating available sub-type names.This PR also improve how wrong character are underlined:
It was broken for some cases by the PR #3403, so I fixed that and also improved it by underlining the (first) whole sequence of wrong characters.