feat: mgr strategy for lagrangeContactBubbleStabilization #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CusiniM
requested review from
rrsettgast,
matteofrigo5,
Guotong-Ren,
castelletto1,
victorapm and
jhuang2601
as code owners
...nearAlgebra/interfaces/hypre/mgrStrategies/LagrangianContactMechanicsBubbleStabilization.hpp
Outdated
Show resolved
Hide resolved
…s/LagrangianContactMechanicsBubbleStabilization.hpp Co-authored-by: Nicola Castelletto <[email protected]>
…StrategyForLagrangeContactBubble
CusiniM
added
flag: no rebaseline
CusiniM
commented
Jan 17, 2025
Comment on lines
277
to
297
| void setILUCoarseSolver( HyprePrecWrapper & solver ) | ||
| { | ||
| /* (Required) Create ILU solver */ | ||
| HYPRE_ILUCreate(&solver.ptr); | ||
|
|
||
| /* (Recommended) General solver options */ | ||
| int const ilu_type = 0; /* 0, 1, 10, 11, 20, 21, 30, 31, 40, 41, 50 */ | ||
| int const max_iter = 1; | ||
| double const tol = 0.0; | ||
| int const reordering = 0; /* 0: none, 1: RCM */ | ||
| int const print_level = 0; | ||
| HYPRE_ILUSetType(solver.ptr, ilu_type); | ||
| HYPRE_ILUSetMaxIter(solver.ptr, max_iter); | ||
| HYPRE_ILUSetTol(solver.ptr, tol); | ||
| HYPRE_ILUSetLocalReordering(solver.ptr, reordering); | ||
| HYPRE_ILUSetPrintLevel(solver.ptr, print_level); | ||
|
|
||
| solver.setup = HYPRE_ILUSetup; | ||
| solver.solve = HYPRE_ILUSolve; | ||
| solver.destroy = HYPRE_ILUDestroy; | ||
| } |
There was a problem hiding this comment.
we could remove this. Unless we want it as an example of how to set a different coarse solver.
CusiniM
commented
Jan 17, 2025
src/coreComponents/physicsSolvers/contact/SolidMechanicsLagrangeContactBubbleStab.cpp
Outdated
Show resolved
Hide resolved
matteofrigo5
approved these changes
Jan 17, 2025
inputFiles/lagrangianContactMechanics/LagrangeContactBubbleStab_FixedSlip_smoke.xml
Outdated
Show resolved
Hide resolved
| setupLabels(); | ||
|
|
||
| // Level 0 | ||
| m_levelFRelaxType[0] = MGRFRelaxationType::l1jacobi; |
There was a problem hiding this comment.
We should investigate with @victorapm the blockJacobi option at some point. Not needed in this PR.
| m_levelGlobalSmootherType[0] = MGRGlobalSmootherType::none; | ||
|
|
||
| // Level 1 | ||
| m_levelFRelaxType[1] = MGRFRelaxationType::l1jacobi; |
castelletto1
approved these changes
Jan 17, 2025
CusiniM
commented
Jan 17, 2025
inputFiles/lagrangianContactMechanics/LagrangeContactBubbleStab_FixedSlip_smoke.xml
Outdated
Show resolved
Hide resolved
CusiniM
added
ci: run code coverage
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3492 +/- ##
===========================================
- Coverage 56.87% 56.85% -0.02%
===========================================
Files 1157 1158 +1
Lines 101244 101273 +29
===========================================
Hits 57580 57580
- Misses 43664 43693 +29 ☔ View full report in Codecov by Sentry. |
CusiniM
deleted the
feature/cusini/mgrStrategyForLagrangeContactBubble
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds and MGR strategy for the saddle point system of:
lagrangeContactBubbleStabilization.