Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: avoid creating files from inside docker container as root #3542

Merged
merged 17 commits into from
Feb 13, 2025

Conversation

rrsettgast
Copy link
Member

@rrsettgast rrsettgast commented Feb 9, 2025

This PR does a few things now:

  • We are having some issues where the docker container will create some files as root. If the job fails and the ci_build_and_test_inside_container.sh script doesn't finish, the runner is no longer usable until someone with root privileges deletes the files. This PR tries to avoid writing files as root.
  • update silo in the spack config. updates hostconfigs for LC
  • move rocky cuda build to streak2
  • fix rtd builds resolves ReadTheDocs failure related to schema.xsd #3539

@rrsettgast rrsettgast self-assigned this Feb 9, 2025
@rrsettgast rrsettgast added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Feb 9, 2025
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.73%. Comparing base (983f60d) to head (7e4cc19).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3542      +/-   ##
===========================================
- Coverage    56.73%   56.73%   -0.01%     
===========================================
  Files         1165     1165              
  Lines       101488   101488              
===========================================
- Hits         57584    57582       -2     
- Misses       43904    43906       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rrsettgast rrsettgast marked this pull request as draft February 12, 2025 21:03
@rrsettgast rrsettgast marked this pull request as ready for review February 12, 2025 21:14
@rrsettgast rrsettgast merged commit 6769693 into develop Feb 13, 2025
24 checks passed
@rrsettgast rrsettgast deleted the bugfix/fixDockerFilePermissions branch February 13, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReadTheDocs failure related to schema.xsd
4 participants