Throw exceptions instead of errors in stringToArray #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
@corbett5 @rrsettgast |
TotoGaz
added a commit
to GEOS-DEV/GEOS
that referenced
this pull request
Apr 14, 2023
?? There we no limitations on who could merge a PR. They are in place now. |
|
I'm not sure there are many protections on submodules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to:
LvArray::input::stringToArray()instead of errors. This will help to add context to these parsing errors by catching these exceptions, as a lot of parsing function & method propose to.GEOS Issue related: #2320
GEOS PR : #2357