Changes needed to run GEOS on M1 #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
the
0 diff
This was referenced Jun 7, 2022
Closed
kgerheiser
reviewed
Jun 9, 2022
| # might need to be revisited for M1 Max/Ultra and M2+. | ||
| # Also, fail if a Linux Arm64 | ||
| if (APPLE) | ||
| elseif (${proc_description} MATCHES "Apple M1") |
There was a problem hiding this comment.
I would add that this might be better as a regex. Apple just releases the M2, so hardcoding M1 may cause an issue.
There was a problem hiding this comment.
@kgerheiser Hmm. I suppose. Maybe
elseif (${proc_description} MATCHES "Apple M")would work? Then we are good until they release an...I dunno "X1" chip or whatever.
Of course, I don't have access to an M1 Max or Ultra yet, so I'm not sure what they report. I tried to read the CMake code to see how CMake generates this string but I got lost in the C++!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tracking branch for M1 support of GEOS.
Current testing (with generous help from @iains), see:
GEOS-ESM/GEOSgcm#417
has shown that GEOS seems to not be happy with
-march=nativeand whatever other flags we do for Aggressive. So, for now, we just make our Aggressive build match that of Release. Testing shows the Release flags seem to be pretty darn good so it's not like we are missing much.