fix(dashboard): Accurate Error Messages #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the NFC ux in the dashboard by making it consistent with how the change/delete of API Keys works, also adds the change/delete NFC code functionality to the admin interface.
Previously, the error messages were inconsistent with what actually happened, for example when scanning the same NFC code the error was incorrect. Should be solved by using the error message directly
noelvandevrie
changed the title
JustSamuel
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should fix the error messaging with the toasts that occur when attempting to scan NFC cards in the dashboard.
#351 #480
Types of changes