Fix phonon (materialsproject#404)

* Small fix for phonon component * Use disabled attribute directly in Button * Update pull-request.yml --------- Co-authored-by: Patrick Huck <[email protected]>
GHzytp · Sep 4, 2024 · 1d58114 · 1d58114
1 parent 4726297
commit 1d58114
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/crystal_toolkit/components/phonon.py b/crystal_toolkit/components/phonon.py
@@ -364,9 +364,18 @@ def _get_data_list_dict(
             "Number of bands": f"{bs.nb_bands:,}",
             "Number of q-points": f"{bs.nb_qpoints:,}",
             # for NAC see https://phonopy.github.io/phonopy/formulation.html#non-analytical-term-correction
-            "Has NAC (see phonopy docs)": bs.has_nac,
-            "Has imaginary frequencies": bs.has_imaginary_freq(),
-            "Has eigen-displacements": bs.has_eigendisplacements,
+            Label(
+                [
+                    "Has ",
+                    html.A(
+                        "NAC",
+                        href="https://phonopy.github.io/phonopy/formulation.html#non-analytical-term-correction",
+                        target="blank",
+                    ),
+                ]
+            ): "Yes" if bs.has_nac else "No",
+            "Has imaginary frequencies": "Yes" if bs.has_imaginary_freq() else "No",
+            "Has eigen-displacements": "Yes" if bs.has_eigendisplacements else "No",
             "Min frequency": min_freq_report,
             "max frequency": f"{max(dos.frequencies):.2f} THz",
         }

diff --git a/crystal_toolkit/helpers/layouts.py b/crystal_toolkit/helpers/layouts.py
@@ -244,7 +244,6 @@ def __init__(
         rounded: bool = False,
         loading: bool = False,
         static: bool = False,
-        disabled: bool = False,
         **kwargs,
     ) -> None:
         """The button is an essential element of any design. It's meant to look and behave as an interactive element of your page.
@@ -261,7 +260,6 @@ def __init__(
         _update_css_class(kwargs, "is-rounded", rounded)
         _update_css_class(kwargs, "is-loading", loading)
         _update_css_class(kwargs, "is-static", static)
-        _update_css_class(kwargs, "is-disabled", disabled)
         super().__init__(*args, **kwargs)