fix(logging): Repair the logging backend (#1695)

GIScience · Feb 19, 2024 · e9bc57f · e9bc57f
2 parents 9983dec + f7ccbfd
commit e9bc57f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 30 deletions.
diff --git a/ors-api/pom.xml b/ors-api/pom.xml
@@ -152,11 +152,6 @@
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-api</artifactId>
         </dependency>
-        <dependency>
-            <groupId>org.slf4j</groupId>
-            <artifactId>slf4j-reload4j</artifactId>
-            <scope>runtime</scope>
-        </dependency>
 
         <dependency>
             <groupId>org.json</groupId>
@@ -189,7 +184,11 @@
                 </exclusion>
             </exclusions>
         </dependency>
-
+        <!-- The following dependency is needed for the Spring Boot Actuator and validates beans -->
+        <dependency>
+            <groupId>org.springframework.boot</groupId>
+            <artifactId>spring-boot-starter-validation</artifactId>
+        </dependency>
         <dependency>
             <groupId>org.springframework.boot</groupId>
             <artifactId>spring-boot-starter-test</artifactId>
@@ -243,12 +242,10 @@
         <dependency>
             <groupId>org.springframework.boot</groupId>
             <artifactId>spring-boot-starter-log4j2</artifactId>
-            <exclusions>
-                <exclusion>
-                    <groupId>org.apache.logging.log4j</groupId>
-                    <artifactId>log4j-slf4j2-impl</artifactId>
-                </exclusion>
-            </exclusions>
+            <!-- Don't exclude log4j-slf4j2-impl -->
+            <!-- This implements log4j logging as well as proper forwarding from slf4j to log4j -->
+            <!-- It is necessary when artifacts in the dependency tree use slf4j but we use log4j -->
+            <!-- Right now, we use log4j2 as logging framework but the graphhopper library uses slf4j -->
         </dependency>
         <dependency>
             <groupId>io.micrometer</groupId>

diff --git a/ors-engine/pom.xml b/ors-engine/pom.xml
@@ -133,21 +133,10 @@
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-api</artifactId>
         </dependency>
-        <dependency>
-            <groupId>org.slf4j</groupId>
-            <artifactId>slf4j-reload4j</artifactId>
-            <scope>runtime</scope>
-        </dependency>
 
         <dependency>
             <groupId>me.tongfei</groupId>
             <artifactId>progressbar</artifactId>
-            <exclusions>
-                <exclusion>
-                    <groupId>org.jline</groupId>
-                    <artifactId>jline</artifactId>
-                </exclusion>
-            </exclusions>
         </dependency>
 
         <dependency>

diff --git a/pom.xml b/pom.xml
@@ -261,13 +261,6 @@
                 <artifactId>slf4j-api</artifactId>
                 <version>${slf4j.version}</version>
             </dependency>
-
-            <dependency>
-                <groupId>org.slf4j</groupId>
-                <artifactId>slf4j-reload4j</artifactId>
-                <version>${slf4j.version}</version>
-            </dependency>
-
         </dependencies>
     </dependencyManagement>