-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme #12
Update readme #12
Conversation
WalkthroughThe recent update introduces enhancements and changes to the installation process, focusing on flexibility and optimization. It adds options for BLAS libraries, including Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- README.md (2 hunks)
Additional comments: 4
README.md (4)
- 37-38: The addition of
blis
as an option for the BLAS library and the introduction ofmicromamba
as a default installer are significant improvements. These changes align with the PR objectives to provide users with more flexibility and efficient tools for installation. However, it's important to ensure that the documentation clearly explains the benefits or use cases for each BLAS option and installer to help users make informed decisions.
Ensure that the documentation elsewhere in the project or in linked resources provides adequate information on when to choose each BLAS option or installer.
- 39-39: Introducing
mamba
as an alternative installer alongsidemicromamba
andconda
offers users a broader range of choices. It's crucial, however, to highlight the differences and recommend scenarios for using each installer to aid users in selecting the most suitable option for their needs.
Verify if additional documentation or tutorials are available for users unfamiliar with these installers, and consider linking to them from the README.
- 43-44: The decision to use
micromamba
by default on both Linux and macOS, and to specifyaccelerate
for macOS andMKL
for Linux as the default BLAS libraries, is a strategic choice that likely optimizes performance for the majority of users. It's essential to ensure that this information is prominently highlighted in the documentation so that users are aware of these defaults and can adjust their installations if necessary.
Confirm that the installation scripts and any associated automation correctly implement these defaults and that there are clear instructions for users who wish to choose different options.
- 55-55: Updating the installation path to include the current date is a thoughtful change that helps prevent overwriting previous installations. This approach enhances the maintainability of installations and allows for easier rollback or comparison between different versions. Ensure that this change is clearly communicated in the installation instructions to avoid confusion among users.
Check if there are any scripts or tools that rely on a static installation path and update them accordingly to accommodate this change.
Summary by CodeRabbit
blis
.micromamba
andmamba
as installation options.micromamba
for Linux and macOS.accelerate
on macOS andMKL
on Linux.