Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MacOSX backend on macOS #15

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Use MacOSX backend on macOS #15

merged 1 commit into from
Apr 29, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Apr 29, 2024 •
edited by coderabbitai bot
Loading

As found by @JulesKouatchou and myself, the MacOSX backend seems to be a LOT better on macOS. This defaults to that on Darwin.

Summary by CodeRabbit

  • Bug Fixes
    • Updated matplotlib backend settings for improved compatibility across different operating systems.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 29, 2024 •
edited
Loading

Walkthrough

The recent update modifies the backend configuration for the matplotlib library in our project scripts. Specifically, it ensures that on macOS systems, the MacOSX backend is used, while on other platforms, the TkAgg backend is employed. This change enhances compatibility and performance across different operating systems.

Changes

File(s) Change Summary
CHANGELOG.md, install_miniconda.bash Updated matplotlib backend handling: MacOSX for macOS, TkAgg for other OS.
Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between a824064 and 09851c5.
Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • install_miniconda.bash (1 hunks)
Additional Context Used
LanguageTool (183)
CHANGELOG.md (183)

Near line 5: Only proper nouns start with an uppercase character (there are exceptions for headlines).
Context: ... in this file. The format is based on [Keep a Changelog](https://keepachangelog.com...

Near line 14: Possible spelling mistake found.
Context: ...eleased] ### Fixed ### Changed - Use MacOSX matplotlib backend on macOS, still use ...

Near line 14: Possible spelling mistake found.
Context: ...] ### Fixed ### Changed - Use MacOSX matplotlib backend on macOS, still use TkAgg on Li...

Near line 14: Possible spelling mistake found.
Context: ... matplotlib backend on macOS, still use TkAgg on Linux ### Added ### Removed ### D...

Near line 26: Possible spelling mistake found.
Context: ...- 2024-04-09 ### Changed - Updated to Miniconda 24.1.2-0. - Updated to Python 3.12 by d...

Near line 28: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... - Updated to Python 3.12 by default. - Updated to use Micromamba by default on Linux. ...

Near line 28: Possible spelling mistake found.
Context: ...ython 3.12 by default. - Updated to use Micromamba by default on Linux. - Added BLIS as an...

Near line 29: Possible spelling mistake found.
Context: ...Micromamba by default on Linux. - Added BLIS as an allowed BLAS. - Enhanced ffnet in...

Near line 29: Possible spelling mistake found.
Context: ...lt on Linux. - Added BLIS as an allowed BLAS. - Enhanced ffnet installation on macOS...

Near line 30: Possible spelling mistake found.
Context: ...ded BLIS as an allowed BLAS. - Enhanced ffnet installation on macOS: The script now c...

Near line 30: Possible spelling mistake found.
Context: ...: The script now conditionally installs ffnet if a gfortran compiler is found. ### A...

Near line 30: Possible spelling mistake found.
Context: ...t now conditionally installs ffnet if a gfortran compiler is found. ### Added - Explic...

Near line 35: Possible spelling mistake found.
Context: ...## Added - Explicit Conda Packages - haversine - ford - autopep8 - mdutils - f...

Near line 38: Possible spelling mistake found.
Context: ... - haversine - ford - autopep8 - mdutils - f90wrap (moved from Pip to Conda) -...

Near line 41: Possible spelling mistake found.
Context: ...p to Conda) - Explicit Pip Packages - wordcloud (moved from Conda to Pip) - meson (re...

Near line 42: Possible spelling mistake found.
Context: ...m Conda to Pip) - meson (required for ffnet) - pybufrkit ### Removed - Explicit...

Near line 43: Possible spelling mistake found.
Context: ...Pip) - meson (required for ffnet) - pybufrkit ### Removed - Explicit Conda Packages...

Near line 48: Possible spelling mistake found.
Context: ... Removed - Explicit Conda Packages - wordcloud (moved to Pip from Conda) - Explicit Pi...

Near line 50: Possible spelling mistake found.
Context: ...from Conda) - Explicit Pip Packages - theano (no longer maintained) - blaze (no lo...

Near line 58: Possible spelling mistake found.
Context: ...2023-10-17 ### Fixed - Fixed possible pygrads install issue - Fixed odd libcxx issue ...

Near line 59: Possible spelling mistake found.
Context: ...sible pygrads install issue - Fixed odd libcxx issue between miniconda and conda-forge...

Near line 59: Possible spelling mistake found.
Context: ... issue - Fixed odd libcxx issue between miniconda and conda-forge - Fixed issue with gfor...

Near line 59: Possible spelling mistake found.
Context: ... odd libcxx issue between miniconda and conda-forge - Fixed issue with gfortran version det...

Near line 60: Possible spelling mistake found.
Context: ...onda and conda-forge - Fixed issue with gfortran version detection ### Added - Added m...

Near line 64: Possible spelling mistake found.
Context: ...n version detection ### Added - Added micromamba support - micromamba is a new, experi...

Near line 65: Possible spelling mistake found.
Context: ...# Added - Added micromamba support - micromamba is a new, experimental, lightweight con...

Near line 65: Possible spelling mistake found.
Context: ...mba is a new, experimental, lightweight conda installer; we use it by default on macO...

Near line 66: Consider using either the past participle “defaulted” or the present participle “defaulting” here.
Context: ... by default on macOS - mamba is still default on Linux - Explicit Conda Packages -...

Near line 70: Possible spelling mistake found.
Context: ...cit Conda Packages - scikit-learn - yamllint - verboselogs - libblas - Defau...

Near line 71: Possible spelling mistake found.
Context: ...kages - scikit-learn - yamllint - verboselogs - libblas - Defaults to using `ac...

Near line 72: Possible spelling mistake found.
Context: ...-learn - yamllint - verboselogs - libblas - Defaults to using accelerate on...

Near line 73: Possible spelling mistake found.
Context: ...ng accelerate on Arm-based macOS, and mkl on Intel-based macOS and Linux - mov...

Near line 74: Possible spelling mistake found.
Context: ...mkl` on Intel-based macOS and Linux - movingpandas - geoviews - hvplot (pinned to 0.8....

Near line 75: Possible spelling mistake found.
Context: ...ed macOS and Linux - movingpandas - geoviews - hvplot (pinned to 0.8.3) - bokeh ...

Near line 76: Possible spelling mistake found.
Context: ...Linux - movingpandas - geoviews - hvplot (pinned to 0.8.3) - bokeh (pinned to ...

Near line 78: Possible spelling mistake found.
Context: ...to 0.8.3) - bokeh (pinned to 3.1) - geopandas - intake - intake-parquet - intak...

Near line 81: Possible spelling mistake found.
Context: ...andas - intake - intake-parquet - intake-xarray - pykdtree - pyogrio - contourpy ...

Near line 82: Possible spelling mistake found.
Context: ... - intake-parquet - intake-xarray - pykdtree - pyogrio - contourpy - sunpy - ...

Near line 83: Possible spelling mistake found.
Context: ...quet - intake-xarray - pykdtree - pyogrio - contourpy - sunpy - Explicit Pip...

Near line 84: Possible spelling mistake found.
Context: ...ake-xarray - pykdtree - pyogrio - contourpy - sunpy - Explicit Pip Packages - ...

Near line 85: Possible spelling mistake found.
Context: ... pykdtree - pyogrio - contourpy - sunpy - Explicit Pip Packages - lxml - j...

Near line 88: Possible spelling mistake found.
Context: ... - sunpy - Explicit Pip Packages - lxml - juliandate - Added example for ffn...

Near line 89: Possible spelling mistake found.
Context: ...y - Explicit Pip Packages - lxml - juliandate - Added example for ffnet - Added chan...

Near line 91: Possible spelling mistake found.
Context: ...xml - juliandate - Added example for ffnet - Added changelog enforcer ### Changed...

Near line 97: Possible spelling mistake found.
Context: ...s are now in the root - Updated example miniconda version to 23.5.2-0 - Updated example P...

Near line 100: Possible spelling mistake found.
Context: ...ion to 3.11 - Explicit Pip Packages - ffnet - Moved to use a Git master branch ...

Near line 101: Consider using a different verb for a more formal wording.
Context: ...e a Git master branch of the package to fix issues with Python3 and scipy - Req...

Near line 101: Possible spelling mistake found.
Context: ... package to fix issues with Python3 and scipy - Requires gfortran 8.3 or higher -...

Near line 102: Possible spelling mistake found.
Context: ...s with Python3 and scipy - Requires gfortran 8.3 or higher - Updated readmes with la...

Near line 103: Possible spelling mistake found.
Context: ...quires gfortran 8.3 or higher - Updated readmes with latest versions ### Removed - Ex...

Near line 108: Possible spelling mistake found.
Context: ... Removed - Explicit Conda Packages - basemap (obsolete, use cartopy) - cubes (caus...

Near line 108: Possible spelling mistake found.
Context: ...nda Packages - basemap (obsolete, use cartopy) - cubes (caused downgrade to Python ...

Near line 111: Possible spelling mistake found.
Context: ...(caused downgrade of many packages) - mdp (obsolete, not supported by 3.11) ## [...

Near line 118: Possible spelling mistake found.
Context: ...## Added - Explicit Conda Packages - wordcloud - zarr - Explicit Pip Packages - r...

Near line 119: Possible spelling mistake found.
Context: ...plicit Conda Packages - wordcloud - zarr - Explicit Pip Packages - ruamel.yam...

Near line 123: Possible spelling mistake found.
Context: ...plicit Pip Packages - ruamel.yaml - tensorflow - evidential-deep-learning - yaplon...

Near line 125: Possible spelling mistake found.
Context: ...orflow - evidential-deep-learning - yaplon ### Changed - Only install pythran ...

Near line 129: Possible spelling mistake found.
Context: ... - yaplon ### Changed - Only install pythran on Linux - Instead of removing the `mp...

Near line 130: Possible spelling mistake found.
Context: ...ranon Linux - Instead of removing thempi*files inbin, we now rename to esm...

Near line 131: Possible spelling mistake found.
Context: ..., we now rename to esmf-mpi*- Movedxgboost` from mamba install to pip (due to pip ...

Near line 142: Possible spelling mistake found.
Context: ...e default installer. If you want to use conda, pass in --conda flag - ffnet is onl...

Near line 142: Possible spelling mistake found.
Context: ...er. If you want to use conda, pass in --conda flag - ffnet is only installed on Linu...

Near line 143: Possible spelling mistake found.
Context: ...o use conda, pass in --conda flag - ffnet is only installed on Linux ### Added ...

Near line 148: Possible spelling mistake found.
Context: ...## Added - Explicit Conda Packages - cython - gsw - pythran - Other Python Pack...

Near line 149: Possible spelling mistake found.
Context: ... Explicit Conda Packages - cython - gsw - pythran - Other Python Packages -...

Near line 150: Possible spelling mistake found.
Context: ...t Conda Packages - cython - gsw - pythran - Other Python Packages - PyGrADS 3 -...

Near line 152: Possible spelling mistake found.
Context: ... - pythran - Other Python Packages - PyGrADS 3 - Added .editorconfig file ## [4.9...

Near line 153: Possible spelling mistake found.
Context: ...r Python Packages - PyGrADS 3 - Added .editorconfig file ## [4.9.2] - 2021-05-04 ### Cha...

Near line 163: Possible spelling mistake found.
Context: ...Use --mamba to use ### Deprecated - Miniconda no longer supports Python 2. From here ...

Near line 169: Possible spelling mistake found.
Context: ...- Explicit Conda Packages - boto3 - questionary - s3fs - timezonefinder - xgrads ...

Near line 170: Possible typo detected.
Context: ... Packages - boto3 - questionary - s3fs - timezonefinder - xgrads ### Remo...

Near line 171: Possible spelling mistake found.
Context: ... - boto3 - questionary - s3fs - timezonefinder - xgrads ### Removed - Removed nump...

Near line 172: Possible spelling mistake found.
Context: ...tionary - s3fs - timezonefinder - xgrads ### Removed - Removed numpy/intel inj...

Near line 176: Possible spelling mistake found.
Context: ...nder - xgrads ### Removed - Removed numpy/intel injection ## [4.8.3] - 2020-08-3...

Near line 182: Possible spelling mistake found.
Context: ...2020-08-31 ### Changed - Moved to use Miniconda installers instead of Anaconda - This...

Near line 184: Possible spelling mistake found.
Context: ... are in now explicitly installed with conda as we now need to install them specific...

Near line 190: Possible spelling mistake found.
Context: ...## Added - Explicit Conda Packages - astropy - babel - beautifulsoup4 - colora...

Near line 193: Possible spelling mistake found.
Context: ...stropy - babel - beautifulsoup4 - colorama - esmpy - fastcache - get_termina...

Near line 194: Possible spelling mistake found.
Context: ...bel - beautifulsoup4 - colorama - esmpy - fastcache - get_terminal_size -...

Near line 195: Possible spelling mistake found.
Context: ...autifulsoup4 - colorama - esmpy - fastcache - get_terminal_size - gmp - green...

Near line 197: Possible spelling mistake found.
Context: ... - fastcache - get_terminal_size - gmp - greenlet - imageio - intel-open...

Near line 198: Possible spelling mistake found.
Context: ...cache - get_terminal_size - gmp - greenlet - imageio - intel-openmp - jbig ...

Near line 199: Possible spelling mistake found.
Context: ..._terminal_size - gmp - greenlet - imageio - intel-openmp - jbig - jupyter ...

Near line 200: Possible spelling mistake found.
Context: ...ze - gmp - greenlet - imageio - intel-openmp - jbig - jupyter - jupyterlab -...

Near line 201: Possible spelling mistake found.
Context: ...eenlet - imageio - intel-openmp - jbig - jupyter - jupyterlab - lzo - ...

Near line 202: Possible spelling mistake found.
Context: ...- imageio - intel-openmp - jbig - jupyter - jupyterlab - lzo - mkl - mkl-...

Near line 203: Possible spelling mistake found.
Context: ...- intel-openmp - jbig - jupyter - jupyterlab - lzo - mkl - mkl-service - mkl...

Near line 204: Possible spelling mistake found.
Context: ... - jbig - jupyter - jupyterlab - lzo - mkl - mkl-service - mkl_fft -...

Near line 205: Possible spelling mistake found.
Context: ... - jupyter - jupyterlab - lzo - mkl - mkl-service - mkl_fft - mkl_ran...

Near line 206: Possible spelling mistake found.
Context: ...yter - jupyterlab - lzo - mkl - mkl-service - mkl_fft - mkl_random - numba ...

Near line 207: Possible spelling mistake found.
Context: ...lab - lzo - mkl - mkl-service - mkl_fft - mkl_random - numba - numpy ...

Near line 207: Possible spelling mistake found.
Context: ... - lzo - mkl - mkl-service - mkl_fft - mkl_random - numba - numpy - ...

Near line 208: Possible spelling mistake found.
Context: ... - mkl - mkl-service - mkl_fft - mkl_random - numba - numpy - pipenv (...

Near line 209: Possible spelling mistake found.
Context: ...-service - mkl_fft - mkl_random - numba - numpy - pipenv (moved from pip) ...

Near line 210: Possible spelling mistake found.
Context: ... - mkl_fft - mkl_random - numba - numpy - pipenv (moved from pip) - proj4<6...

Near line 211: Possible spelling mistake found.
Context: ... - mkl_random - numba - numpy - pipenv (moved from pip) - proj4<6 (Python 2)...

Near line 213: Possible spelling mistake found.
Context: ...ed from pip) - proj4<6 (Python 2) - proj (Python 3) - pydap - pygrib - pyp...

Near line 214: Possible spelling mistake found.
Context: ...j4<6 (Python 2) - proj (Python 3) - pydap - pygrib - pypng - pytables - p...

Near line 215: Possible spelling mistake found.
Context: ...on 2) - proj (Python 3) - pydap - pygrib - pypng - pytables - pytest - s...

Near line 216: Possible spelling mistake found.
Context: ...roj (Python 3) - pydap - pygrib - pypng - pytables - pytest - seaborn -...

Near line 217: Possible spelling mistake found.
Context: ...n 3) - pydap - pygrib - pypng - pytables - pytest - seaborn - scipy - sp...

Near line 218: Possible spelling mistake found.
Context: ...p - pygrib - pypng - pytables - pytest - seaborn - scipy - sphinxcontrib...

Near line 219: Possible spelling mistake found.
Context: ...b - pypng - pytables - pytest - seaborn - scipy - sphinxcontrib - tbb -...

Near line 220: Possible spelling mistake found.
Context: ... - pytables - pytest - seaborn - scipy - sphinxcontrib - tbb - tbb4py ...

Near line 221: Possible spelling mistake found.
Context: ...es - pytest - seaborn - scipy - sphinxcontrib - tbb - tbb4py - xesmf - xgcm ...

Near line 222: Possible spelling mistake found.
Context: ...seaborn - scipy - sphinxcontrib - tbb - tbb4py - xesmf - xgcm - Explic...

Near line 223: Possible typo detected.
Context: ... - scipy - sphinxcontrib - tbb - tbb4py - xesmf - xgcm - Explicit Pip Pack...

Near line 224: Possible spelling mistake found.
Context: ... - sphinxcontrib - tbb - tbb4py - xesmf - xgcm - Explicit Pip Packages - b...

Near line 225: Possible spelling mistake found.
Context: ...ontrib - tbb - tbb4py - xesmf - xgcm - Explicit Pip Packages - blaze - ...

Near line 229: Possible typo detected.
Context: ... - Explicit Pip Packages - blaze - h5py - metpy (Python 3 only) - pycirclec...

Near line 230: Possible spelling mistake found.
Context: ...cit Pip Packages - blaze - h5py - metpy (Python 3 only) - pycircleci (Python ...

Near line 231: Possible spelling mistake found.
Context: ... - h5py - metpy (Python 3 only) - pycircleci (Python 3 only) - siphon (Python 3 on...

Near line 233: Possible spelling mistake found.
Context: ... 3 only) - siphon (Python 3 only) - theano ### Removed - Explicit Conda Packages...

Near line 238: Possible spelling mistake found.
Context: ... Removed - Explicit Conda Packages - theano (moved to pip) - blaze (moved to pip)...

Near line 247: Possible spelling mistake found.
Context: ...- Explicit Conda Packages - gooey - hpccm - rasterio - Explicit Pip Packages ...

Near line 248: Possible spelling mistake found.
Context: ... Conda Packages - gooey - hpccm - rasterio - Explicit Pip Packages - f90wrap -...

Near line 251: Possible spelling mistake found.
Context: ...- Explicit Pip Packages - f90wrap - pymp-pypi ### Removed - Explicit Conda Packages...

Near line 257: Possible spelling mistake found.
Context: ... - Explicit Conda Packages - cis - django - f90wrap (moved to pip) - joblib ...

Near line 259: Possible spelling mistake found.
Context: ...- django - f90wrap (moved to pip) - joblib - launcher - mock - psycopg2 - ...

Near line 263: Possible spelling mistake found.
Context: ... - launcher - mock - psycopg2 - pygrib - util-linux - xorg-libsm ### Chan...

Near line 264: Possible spelling mistake found.
Context: ...er - mock - psycopg2 - pygrib - util-linux - xorg-libsm ### Changed - Moved so...

Near line 265: Possible spelling mistake found.
Context: ... psycopg2 - pygrib - util-linux - xorg-libsm ### Changed - Moved some conda packag...

Near line 269: Possible spelling mistake found.
Context: ...- xorg-libsm ### Changed - Moved some conda packages to an earlier conda install ...

Near line 269: Possible spelling mistake found.
Context: ...Moved some conda packages to an earlier conda install command to satisfy dependency ...

Near line 276: Possible spelling mistake found.
Context: ...only those expressly asked for with a conda install. Some "basic" packages are fro...

Near line 277: Possible spelling mistake found.
Context: ..." packages are from Anaconda, while conda will of course install other dependenci...

Near line 277: Consider adding two commas here.
Context: ... are from Anaconda, while conda will of course install other dependencies as well. For...

Near line 277: Possible spelling mistake found.
Context: ...ther dependencies as well. For example, numpy is not in this list, but is part of GEO...

Near line 277: Possible spelling mistake found.
Context: ...mpy is not in this list, but is part of GEOSpyD - Explicit Conda Packages - argcomple...

Near line 279: Possible spelling mistake found.
Context: ...f GEOSpyD - Explicit Conda Packages - argcomplete - basemap - biggus - biopython ...

Near line 280: Possible spelling mistake found.
Context: ...icit Conda Packages - argcomplete - basemap - biggus - biopython - blaze - ...

Near line 281: Possible spelling mistake found.
Context: ...ackages - argcomplete - basemap - biggus - biopython - blaze - cartopy -...

Near line 282: Possible spelling mistake found.
Context: ... argcomplete - basemap - biggus - biopython - blaze - cartopy - cdsapi - cm...

Near line 284: Possible spelling mistake found.
Context: ... - biggus - biopython - blaze - cartopy - cdsapi - cmocean - cis - conf...

Near line 285: Possible spelling mistake found.
Context: ... - biopython - blaze - cartopy - cdsapi - cmocean - cis - configargparse ...

Near line 286: Possible spelling mistake found.
Context: ...on - blaze - cartopy - cdsapi - cmocean - cis - configargparse - configob...

Near line 288: Possible spelling mistake found.
Context: ...topy - cdsapi - cmocean - cis - configargparse - configobj - cubes - django - ...

Near line 289: Possible spelling mistake found.
Context: ... cmocean - cis - configargparse - configobj - cubes - django - eofs - f90nm...

Near line 291: Possible spelling mistake found.
Context: ...figargparse - configobj - cubes - django - eofs - f90nml - f90wrap - gda...

Near line 292: Possible spelling mistake found.
Context: ... - configobj - cubes - django - eofs - f90nml - f90wrap - gdal - geo...

Near line 295: Possible spelling mistake found.
Context: ...ngo - eofs - f90nml - f90wrap - gdal - geotiff - iris - joblib - krb...

Near line 296: Possible spelling mistake found.
Context: ...ofs - f90nml - f90wrap - gdal - geotiff - iris - joblib - krb5 - launch...

Near line 298: Possible spelling mistake found.
Context: ...0wrap - gdal - geotiff - iris - joblib - krb5 - launcher - libmo_unpack ...

Near line 301: Possible spelling mistake found.
Context: ...is - joblib - krb5 - launcher - libmo_unpack - matplotlib - mdp - mock ...

Near line 302: Possible spelling mistake found.
Context: ... krb5 - launcher - libmo_unpack - matplotlib - mdp - mock - mo_pack - nc_tim...

Near line 303: Possible spelling mistake found.
Context: ...her - libmo_unpack - matplotlib - mdp - mock - mo_pack - nc_time_axis ...

Near line 306: Possible spelling mistake found.
Context: ...lotlib - mdp - mock - mo_pack - nc_time_axis - netcdf4 - pip - plotl...

Near line 309: Possible spelling mistake found.
Context: ... - nc_time_axis - netcdf4 - pip - plotly - psycopg2 - pyasn1 - pygrib - ...

Near line 312: Possible spelling mistake found.
Context: ... - plotly - psycopg2 - pyasn1 - pygrib - pyhdf - pyspharm - redis - re...

Near line 313: Possible spelling mistake found.
Context: ... - psycopg2 - pyasn1 - pygrib - pyhdf - pyspharm - redis - redis-py -...

Near line 314: Possible spelling mistake found.
Context: ...pg2 - pyasn1 - pygrib - pyhdf - pyspharm - redis - redis-py - requests-too...

Near line 315: Possible spelling mistake found.
Context: ...1 - pygrib - pyhdf - pyspharm - redis - redis-py - requests-toolbelt - ...

Near line 316: Possible spelling mistake found.
Context: ...ib - pyhdf - pyspharm - redis - redis-py - requests-toolbelt - seawater - ...

Near line 317: Possible spelling mistake found.
Context: ... - pyspharm - redis - redis-py - requests-toolbelt - seawater - sockjs-tornado - sph...

Near line 319: Possible spelling mistake found.
Context: ... - requests-toolbelt - seawater - sockjs-tornado - sphinx_rtd_theme - theano - tk ...

Near line 320: Possible spelling mistake found.
Context: ... seawater - sockjs-tornado - sphinx_rtd_theme - theano - tk - twine - u...

Near line 321: Possible spelling mistake found.
Context: ...sockjs-tornado - sphinx_rtd_theme - theano - tk - twine - ujson - util-lin...

Near line 322: Possible spelling mistake found.
Context: ...ado - sphinx_rtd_theme - theano - tk - twine - ujson - util-linux (Lin...

Near line 324: Possible spelling mistake found.
Context: ...d_theme - theano - tk - twine - ujson - util-linux (Linux only) - virtual...

Near line 325: Possible spelling mistake found.
Context: ...- theano - tk - twine - ujson - util-linux (Linux only) - virtualenv - wxpytho...

Near line 326: Possible spelling mistake found.
Context: ...- ujson - util-linux (Linux only) - virtualenv - wxpython - wsgiref (Python 2 only...

Near line 327: Possible spelling mistake found.
Context: ...l-linux (Linux only) - virtualenv - wxpython - wsgiref (Python 2 only) - windsph...

Near line 328: Possible spelling mistake found.
Context: ...x only) - virtualenv - wxpython - wsgiref (Python 2 only) - windspharm - xarr...

Near line 329: Possible spelling mistake found.
Context: ...xpython - wsgiref (Python 2 only) - windspharm - xarray - xgboost - xorg-kbproto...

Near line 330: Possible spelling mistake found.
Context: ...iref (Python 2 only) - windspharm - xarray - xgboost - xorg-kbproto - xorg-l...

Near line 331: Possible spelling mistake found.
Context: ...n 2 only) - windspharm - xarray - xgboost - xorg-kbproto - xorg-libice - xo...

Near line 332: Possible spelling mistake found.
Context: ...- windspharm - xarray - xgboost - xorg-kbproto - xorg-libice - xorg-libsm - xorg...

Near line 333: Possible spelling mistake found.
Context: ...xarray - xgboost - xorg-kbproto - xorg-libice - xorg-libsm - xorg-libx11 - xorg...

Near line 334: Possible spelling mistake found.
Context: ...st - xorg-kbproto - xorg-libice - xorg-libsm - xorg-libx11 - xorg-libxext - xo...

Near line 336: Possible spelling mistake found.
Context: ...bice - xorg-libsm - xorg-libx11 - xorg-libxext - xorg-libxrender - xorg-renderprot...

Near line 337: Possible spelling mistake found.
Context: ...sm - xorg-libx11 - xorg-libxext - xorg-libxrender - xorg-renderproto - xorg-xextproto...

Near line 338: Possible spelling mistake found.
Context: ... - xorg-libxext - xorg-libxrender - xorg-renderproto - xorg-xextproto - xorg-xproto - Ex...

Near line 339: Possible spelling mistake found.
Context: ...org-libxrender - xorg-renderproto - xorg-xextproto - xorg-xproto - Explicit Pip Packages...

Near line 340: Possible spelling mistake found.
Context: ...xorg-renderproto - xorg-xextproto - xorg-xproto - Explicit Pip Packages - ffnet - p...

Near line 342: Possible spelling mistake found.
Context: ...xorg-xproto - Explicit Pip Packages - ffnet - pipenv - PyRTF3 (Python 3) - rt...

Near line 343: Possible spelling mistake found.
Context: ...o - Explicit Pip Packages - ffnet - pipenv - PyRTF3 (Python 3) - rtfw (Python ...

Near line 345: Possible spelling mistake found.
Context: ...et - pipenv - PyRTF3 (Python 3) - rtfw (Python 2) - Other Python Packages - ...

Near line 347: Possible spelling mistake found.
Context: ... (Python 2) - Other Python Packages - PyGrADS (Python 2) - Code injections - Fix fo...

Near line 349: Possible typo detected.
Context: ...Python 2) - Code injections - Fix for f2py and numpy - Fix for numpy and Intel ...

Near line 349: Possible spelling mistake found.
Context: ... - Code injections - Fix for f2py and numpy - Fix for numpy and Intel - Make Tk...

Near line 350: Possible spelling mistake found.
Context: ... - Fix for f2py and numpy - Fix for numpy and Intel - Make TkAgg the default ma...

Near line 351: Possible spelling mistake found.
Context: ...py - Fix for numpy and Intel - Make TkAgg the default matplotlib backend as that ...

Near line 351: Possible spelling mistake found.
Context: ...py and Intel - Make TkAgg the default matplotlib backend as that is the only one support...

ShellCheck (58)
install_miniconda.bash (58)

[warning] 38-38: NODE appears unused. Verify use (or export if used externally).

[info] 286-286: Double quote to prevent globbing and word splitting.

[info] 287-287: Double quote to prevent globbing and word splitting.

[warning] 288-288: GFORTRAN_PATCH appears unused. Verify use (or export if used externally).

[info] 288-288: Double quote to prevent globbing and word splitting.

[info] 354-354: Double quote to prevent globbing and word splitting.

[info] 386-386: Double quote to prevent globbing and word splitting.

[info] 386-386: Double quote to prevent globbing and word splitting.

[info] 391-391: Double quote to prevent globbing and word splitting.

[info] 391-391: Double quote to prevent globbing and word splitting.

[info] 391-391: Double quote to prevent globbing and word splitting.

[info] 391-391: Double quote to prevent globbing and word splitting.

[info] 413-413: Double quote to prevent globbing and word splitting.

[info] 413-413: Double quote to prevent globbing and word splitting.

[info] 413-413: Double quote to prevent globbing and word splitting.

[warning] 425-425: Use "$@" (with quotes) to prevent whitespace problems.

[info] 425-425: Double quote to prevent globbing and word splitting.

[info] 430-430: Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

[info] 432-432: Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

[info] 433-433: Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

[info] 434-434: Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

[warning] 434-434: Use "$@" (with quotes) to prevent whitespace problems.

[info] 434-434: Double quote to prevent globbing and word splitting.

[info] 435-435: Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

[info] 439-439: Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

[info] 441-441: Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

[info] 442-442: Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

[info] 443-443: Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

[warning] 443-443: Use "$@" (with quotes) to prevent whitespace problems.

[info] 443-443: Double quote to prevent globbing and word splitting.

[info] 444-444: Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

[info] 454-454: Double quote to prevent globbing and word splitting.

[info] 467-467: Double quote to prevent globbing and word splitting.

[info] 496-496: Double quote to prevent globbing and word splitting.

[info] 508-508: Double quote to prevent globbing and word splitting.

[info] 589-589: Double quote to prevent globbing and word splitting.

[info] 605-605: Double quote to prevent globbing and word splitting.

[info] 643-643: Double quote to prevent globbing and word splitting.

[info] 648-648: Double quote to prevent globbing and word splitting.

[warning] 657-657: Use "${var:?}" to ensure this never expands to / .

[info] 657-657: Double quote to prevent globbing and word splitting.

[info] 660-660: Double quote to prevent globbing and word splitting.

[info] 660-660: Double quote to prevent globbing and word splitting.

[info] 662-662: Double quote to prevent globbing and word splitting.

[info] 664-664: Double quote to prevent globbing and word splitting.

[info] 664-664: Double quote to prevent globbing and word splitting.

[info] 668-668: Double quote to prevent globbing and word splitting.

[info] 668-668: Double quote to prevent globbing and word splitting.

[info] 670-670: Double quote to prevent globbing and word splitting.

[info] 674-674: Double quote to prevent globbing and word splitting.

[info] 674-674: Double quote to prevent globbing and word splitting.

[info] 681-681: Double quote to prevent globbing and word splitting.

[info] 681-681: Double quote to prevent globbing and word splitting.

[info] 683-683: Double quote to prevent globbing and word splitting.

[info] 683-683: Double quote to prevent globbing and word splitting.

[info] 688-688: Double quote to prevent globbing and word splitting.

[info] 697-697: Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

[info] 697-697: Double quote to prevent globbing and word splitting.

Additional comments not posted (2)
CHANGELOG.md (1)

14-14: Ensure the backend change is clearly documented in the installation or setup guide as well.

This is to ensure that users are aware of the backend changes and can adjust their setups if necessary.

install_miniconda.bash (1)

677-684: Set the default backend for matplotlib based on the operating system.

This change correctly sets the MacOSX backend for macOS systems and TkAgg for others, aligning with the PR's objectives to optimize performance on macOS.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mathomp4 mathomp4 merged commit c14e8f1 into main Apr 29, 2024
1 check passed
@mathomp4 mathomp4 deleted the feature/mathomp4/mac-backend branch April 29, 2024 20:29
@mathomp4 mathomp4 restored the feature/mathomp4/mac-backend branch April 29, 2024 20:29
@mathomp4 mathomp4 deleted the feature/mathomp4/mac-backend branch July 23, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mathomp4