Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add f2py3 symlink #19

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Add f2py3 symlink #19

merged 1 commit into from
Jun 11, 2024

Conversation

mathomp4
Copy link
Member

This PR adds a symlink of f2py to f2py3. This helps in the mixed python2/3 cases still sadly in use for GMAO

@mathomp4 mathomp4 added the enhancement New feature or request label Jun 11, 2024
@mathomp4 mathomp4 self-assigned this Jun 11, 2024
Copy link
Contributor

coderabbitai bot commented Jun 11, 2024

Walkthrough

The recent changes address an issue with the detection of the f2py tool by creating a symbolic link from f2py to f2py3. This ensures compatibility with Python 3 and prevents the occasional incorrect detection of f2py during discovery processes.

Changes

Files Change Summary
CHANGELOG.md Added a note about creating a symlink of f2py to f2py3 to fix detection issues.
install_miniconda.bash Implemented the creation of a symbolic link f2py pointing to f2py3 for Python 3 compatibility.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 07bb325 and b508eae.

Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • install_miniconda.bash (1 hunks)
Additional context used
LanguageTool
CHANGELOG.md

[style] ~14-~14: Consider using a different verb for a more formal wording. (FIX_RESOLVE)
Context: ... Make a symlink of f2py to f2py3 to fix an issue with the wrong f2py being fo...


[style] ~54-~54: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... - Updated to Python 3.12 by default. - Updated to use Micromamba by default on Linux. ...


[grammar] ~92-~92: Consider using either the past participle “defaulted” or the present participle “defaulting” here. (BEEN_PART_AGREEMENT)
Context: ... by default on macOS - mamba is still default on Linux - Explicit Conda Packages -...


[style] ~127-~127: Consider using a different verb for a more formal wording. (FIX_RESOLVE)
Context: ...e a Git master branch of the package to fix issues with Python3 and scipy - Req...


[typographical] ~303-~303: Consider adding two commas here. (OF_COURSE_COMMA)
Context: ... are from Anaconda, while conda will of course install other dependencies as well. For...

Markdownlint
CHANGELOG.md

27-27: null (MD034, no-bare-urls)
Bare URL used

Shellcheck
install_miniconda.bash

[warning] 38-38: NODE appears unused. Verify use (or export if used externally). (SC2034)


[warning] 288-288: GFORTRAN_PATCH appears unused. Verify use (or export if used externally). (SC2034)


[warning] 425-425: Use "$@" (with quotes) to prevent whitespace problems. (SC2048)


[warning] 434-434: Use "$@" (with quotes) to prevent whitespace problems. (SC2048)


[warning] 443-443: Use "$@" (with quotes) to prevent whitespace problems. (SC2048)


[warning] 668-668: Use "${var:?}" to ensure this never expands to / . (SC2115)

@mathomp4 mathomp4 merged commit ba19588 into main Jun 11, 2024
2 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/f2py3-link branch June 11, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant