-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add f2py3 symlink #19
Conversation
WalkthroughThe recent changes address an issue with the detection of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- install_miniconda.bash (1 hunks)
Additional context used
LanguageTool
CHANGELOG.md
[style] ~14-~14: Consider using a different verb for a more formal wording. (FIX_RESOLVE)
Context: ... Make a symlink off2py
tof2py3
to fix an issue with the wrongf2py
being fo...
[style] ~54-~54: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... - Updated to Python 3.12 by default. - Updated to use Micromamba by default on Linux. ...
[grammar] ~92-~92: Consider using either the past participle “defaulted” or the present participle “defaulting” here. (BEEN_PART_AGREEMENT)
Context: ... by default on macOS - mamba is still default on Linux - Explicit Conda Packages -...
[style] ~127-~127: Consider using a different verb for a more formal wording. (FIX_RESOLVE)
Context: ...e a Git master branch of the package to fix issues with Python3 and scipy - Req...
[typographical] ~303-~303: Consider adding two commas here. (OF_COURSE_COMMA)
Context: ... are from Anaconda, while conda will of course install other dependencies as well. For...
Markdownlint
CHANGELOG.md
27-27: null (MD034, no-bare-urls)
Bare URL used
Shellcheck
install_miniconda.bash
[warning] 38-38: NODE appears unused. Verify use (or export if used externally). (SC2034)
[warning] 288-288: GFORTRAN_PATCH appears unused. Verify use (or export if used externally). (SC2034)
[warning] 425-425: Use "$@" (with quotes) to prevent whitespace problems. (SC2048)
[warning] 434-434: Use "$@" (with quotes) to prevent whitespace problems. (SC2048)
[warning] 443-443: Use "$@" (with quotes) to prevent whitespace problems. (SC2048)
[warning] 668-668: Use "${var:?}" to ensure this never expands to / . (SC2115)
This PR adds a symlink of f2py to f2py3. This helps in the mixed python2/3 cases still sadly in use for GMAO