-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Miniconda 24.5.0 and add uxarray #21
Conversation
This PR adds uxarray as an explicit conda package and updates the Miniconda version to 24.5.0
WalkthroughThe recent updates primarily focus on upgrading the Miniconda version from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (3)
README.md (2)
18-18
: Grammar correction: Use 'installation' instead of 'install'.The word 'install' is used as a noun, which is incorrect. Consider using 'installation' for clarity.
Use this diff to fix the grammar:
will create an install at: + will create an installation at:
Tools
LanguageTool
[grammar] ~18-~18: The word ‘install’ is not a noun.
Context: ...prefix /opt/GEOSpyDwill create an install at:
/opt/GEOSpyD/24.5.0-0_py3.12/YY...(A_INSTALL)
19-19
: Specify language for fenced code blocks.To improve readability and adhere to markdownlint rules, specify the language for fenced code blocks.
Use this diff to specify the language:
+/opt/GEOSpyD/24.5.0-0_py3.12/YYYY-MM-DD
Tools
Markdownlint
19-19: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
CHANGELOG.md (1)
15-15
: Style improvement: Use formal wording.Consider using a more formal verb like 'Create' instead of 'Make' for better clarity and professionalism.
Use this diff to improve the style:
- Make a symlink of `f2py` to `f2py3` to fix an issue with the wrong `f2py` being found sometimes on discover + Create a symlink of `f2py` to `f2py3` to resolve an issue with the wrong `f2py` being found sometimes on discoverTools
LanguageTool
[style] ~15-~15: Consider using a different verb for a more formal wording.
Context: ... Make a symlink off2py
tof2py3
to fix an issue with the wrongf2py
being fo...(FIX_RESOLVE)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- CHANGELOG.md (1 hunks)
- README.GMAO (1 hunks)
- README.NAS (1 hunks)
- README.NCCS (1 hunks)
- README.md (3 hunks)
- install_miniconda.bash (2 hunks)
Files skipped from review due to trivial changes (3)
- README.GMAO
- README.NAS
- README.NCCS
Additional context used
LanguageTool
README.md
[grammar] ~18-~18: The word ‘install’ is not a noun.
Context: ...prefix /opt/GEOSpyDwill create an install at:
/opt/GEOSpyD/24.5.0-0_py3.12/YY...(A_INSTALL)
CHANGELOG.md
[style] ~15-~15: Consider using a different verb for a more formal wording.
Context: ... Make a symlink off2py
tof2py3
to fix an issue with the wrongf2py
being fo...(FIX_RESOLVE)
Markdownlint
README.md
19-19: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
Additional comments not posted (1)
install_miniconda.bash (1)
62-62
: LGTM!The updates to the Miniconda version and the addition of the
uxarray
package are correctly implemented.Also applies to: 585-586
This PR adds uxarray as an explicit conda package and updates the Miniconda version to 24.5.0