Feature/helics3 update #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enum names in utils.jl and api.jl
version 3.3.2 of the helics headers. it was updated to 3.3.1
changes for debugging failing tests.
autobroker as it doesn't seem to be working.
correcting missed helics 2 function call with helics 3 one
removing obsolete tests
Codecov ReportBase: 90.48% // Head: 60.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
===========================================
- Coverage 90.48% 60.44% -30.05%
===========================================
Files 6 6
Lines 683 1853 +1170
===========================================
+ Hits 618 1120 +502
- Misses 65 733 +668
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Coveralls uploading seems to be broken; julia action for uploading to coveralls may be outdated.
… into feature/helics3Update
nightlark
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HELICS v3 update to julia bindings and tests. all tests are passing.