Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helics3.4 update #24

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Helics3.4 update #24

merged 2 commits into from
Feb 9, 2023

Conversation

afisher1
Copy link
Member

@afisher1 afisher1 commented Jan 28, 2023

This has all the HELICS v3.4 api updates.

Steps to update the Julia Language Bindings.

  1. Execute generate.jl in the HELICS.jl/scripts directory. This script updates HELICS.jl/src/common.jl and HELICS.jl/src/lib.jl with the contents of the helics.h minus all the doc strings.
  2. Update, by hand, HELICS.jl/src/enums.jl to reflect changes made in HELICS.jl/src/common.jl. Grab pertinent doc strings from helics.h and place it in enums.jl.
  3. Update, by hand, HELICS.jl/src/api.jl to reflect changes made in HELICS.jl/src/lib.jl. Grab pertinent doc strings from helics.h and place it in api.jl.
  4. Update version number in Project.toml
  5. Push to repository.

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Base: 60.44% // Head: 60.18% // Decreases project coverage by -0.26% ⚠️

Coverage data is based on head (91af5c6) compared to base (1ef9711).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   60.44%   60.18%   -0.26%     
==========================================
  Files           6        6              
  Lines        1853     1861       +8     
==========================================
  Hits         1120     1120              
- Misses        733      741       +8     
Impacted Files Coverage Δ
src/api.jl 58.94% <0.00%> (-0.25%) ⬇️
src/enums.jl 0.00% <ø> (ø)
src/lib.jl 61.70% <0.00%> (-0.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nightlark
Copy link
Member

Does the Julia interface mark deprecated functions in some way?

@afisher1
Copy link
Member Author

afisher1 commented Feb 6, 2023

Not unless we do so in api.jl explicitly I believe.

@afisher1 afisher1 merged commit 1805e37 into master Feb 9, 2023
@afisher1 afisher1 deleted the helics3.4Update branch February 9, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants