Add check for exported_symbols_list linker option on macOS #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightlark
added
the
Installation/build
phlptp
approved these changes
Dec 27, 2024
|
can we merge this or is there more work to be done? |
nightlark
force-pushed
the
add-macos-exported_symbols_list-linker-check
branch
from
17abe60 to
8bdfc8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linker included with the zig c/c++ compiler doesn't support the exported_symbols_list linker option on macOS. For c/c++ compilation, I think zig is just using llvm/clang, but I guess they don't use the linker from llvm.