v3.5.3 updates #24
Merged
v3.5.3 updates #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding poetry project file for matHELICS python environment.
13 tasks
|
It looks like in the CI job workflow we need to bump up what macOS runner is used (macos-11 is no longer available). |
Update macOS CI runner to macos-13
|
@afisher1 there are errors running the tests -- any ideas? https://github.com/GMLC-TDC/matHELICS/actions/runs/11281905813/job/31378209051?pr=24#step:9:17 |
|
Bumping up the test to use MATLAB 2023b for the CI tests resolved the issue. Probably due to using emulation on macOS with MATLAB 2021a. |
nightlark
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds updates for v3.5.3 of HELICS. Also adding poetry project file for matHELICS binding generation source code python environment.