Skip to content

Commit

Permalink
Remove prop-types from re-exports (#4493)
Browse files Browse the repository at this point in the history
  • Loading branch information
cmdcolin authored Jul 25, 2024
1 parent e96a76f commit f05fb7b
Show file tree
Hide file tree
Showing 13 changed files with 1 addition and 30 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@
"npm-run-all": "^4.1.5",
"oclif": "^4.0.0",
"prettier": "^3.2.5",
"prop-types": "^15.0.0",
"react": "^18.0.0",
"react-dev-utils": "^12.0.1",
"react-dom": "^18.0.0",
Expand Down
1 change: 0 additions & 1 deletion packages/core/ReExports/list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ export default [
'tss-react/mui',
'@material-ui/core',
'@mui/material',
'prop-types',

'@mui/material/styles',
'@material-ui/core/styles',
Expand Down
2 changes: 0 additions & 2 deletions packages/core/ReExports/modules.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import * as mobx from 'mobx'
import * as mst from 'mobx-state-tree'
import * as mxreact from 'mobx-react'
import { makeStyles } from 'tss-react/mui'
import PropTypes from 'prop-types'

import * as MUIStyles from '@mui/material/styles'
import * as MUIUtils from '@mui/material/utils'
Expand Down Expand Up @@ -525,7 +524,6 @@ const libs = {
alpha: MUIStyles.alpha,
useTheme: MUIStyles.useTheme,
},
'prop-types': PropTypes,

// end special case
// material-ui subcomponents, should get rid of these
Expand Down
1 change: 0 additions & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
"mobx": "^6.0.0",
"mobx-react": "^9.0.0",
"mobx-state-tree": "^5.0.0",
"prop-types": "^15.0.0",
"react": ">=16.8.0",
"react-dom": ">=16.8.0",
"rxjs": "^7.0.0",
Expand Down
17 changes: 0 additions & 17 deletions packages/core/util/types/mst.ts
Original file line number Diff line number Diff line change
@@ -1,25 +1,8 @@
import { types } from 'mobx-state-tree'
import propTypes from 'prop-types'
import { PropTypes as MxPropTypes } from 'mobx-react'

import { nanoid } from '../nanoid'

export const ElementId = types.optional(types.identifier, () => nanoid())

// PropTypes that are useful when working with instances of these in react components
export const PropTypes = {
Region: propTypes.shape({
refName: propTypes.string.isRequired,
start: propTypes.number.isRequired,
end: propTypes.number.isRequired,
}),
ConfigSchema: MxPropTypes.objectOrObservableObject,
Feature: propTypes.shape({
get: propTypes.func.isRequired,
id: propTypes.func.isRequired,
}),
}

export const NoAssemblyRegion = types
.model('NoAssemblyRegion', {
refName: types.string,
Expand Down
1 change: 0 additions & 1 deletion plugins/comparative-adapters/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"mobx": "^6.0.0",
"mobx-react": "^9.0.0",
"mobx-state-tree": "^5.0.0",
"prop-types": "^15.0.0",
"react": ">=16.8.0",
"react-dom": ">=16.8.0",
"rxjs": "^7.0.0"
Expand Down
1 change: 0 additions & 1 deletion plugins/lollipop/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
"mobx": "^6.0.0",
"mobx-react": "^9.0.0",
"mobx-state-tree": "^5.0.0",
"prop-types": "^15.0.0",
"react": ">=16.8.0"
},
"distModule": "esm/index.js",
Expand Down
1 change: 0 additions & 1 deletion products/jbrowse-desktop/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@
"mobx-state-tree": "^5.0.0",
"node-fetch": "^2.6.0",
"prompts": "^2.4.2",
"prop-types": "^15.7.2",
"react": "^18.0.0",
"react-dev-utils": "^12.0.1",
"react-dom": "^18.0.0",
Expand Down
1 change: 0 additions & 1 deletion products/jbrowse-react-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@
"mobx-react": "^9.0.0",
"mobx-state-tree": "^5.0.0",
"pako": "^2.1.0",
"prop-types": "^15.0.0",
"react-error-boundary": "^4.0.0",
"rxjs": "^7.0.0",
"tss-react": "^4.4.1",
Expand Down
1 change: 0 additions & 1 deletion products/jbrowse-react-circular-genome-view/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
"mobx": "^6.6.0",
"mobx-react": "^9.0.0",
"mobx-state-tree": "^5.0.0",
"prop-types": "^15.0.0",
"rxjs": "^7.0.0",
"tss-react": "^4.4.1"
},
Expand Down
1 change: 0 additions & 1 deletion products/jbrowse-react-linear-genome-view/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@
"mobx": "^6.6.0",
"mobx-react": "^9.0.0",
"mobx-state-tree": "^5.0.0",
"prop-types": "^15.0.0",
"rxjs": "^7.0.0",
"tss-react": "^4.4.1"
},
Expand Down
1 change: 0 additions & 1 deletion products/jbrowse-web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
"mobx-state-tree": "^5.0.0",
"pako": "^2.1.0",
"prompts": "^2.4.2",
"prop-types": "^15.7.2",
"react": "^18.0.0",
"react-dev-utils": "^12.0.1",
"react-dom": "^18.0.0",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -13615,7 +13615,7 @@ promzard@^1.0.0:
dependencies:
read "^3.0.1"

prop-types@^15.0.0, prop-types@^15.6.2, prop-types@^15.7.2, prop-types@^15.8.1:
prop-types@^15.6.2, prop-types@^15.7.2, prop-types@^15.8.1:
version "15.8.1"
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.8.1.tgz#67d87bf1a694f48435cf332c24af10214a3140b5"
integrity sha512-oj87CgZICdulUohogVAR7AjlC0327U4el4L6eAvOqCeudMDVU0NThNaV+b9Df4dXgSP1gXMTnPdhfe/2qDH5cg==
Expand Down

0 comments on commit f05fb7b

Please sign in to comment.