-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bookmark highlight to overview scale bar #4266
Conversation
…ht URL param functionality
Todos:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4266 +/- ##
==========================================
- Coverage 62.68% 62.64% -0.04%
==========================================
Files 1087 1088 +1
Lines 31392 31427 +35
Branches 7493 7505 +12
==========================================
+ Hits 19678 19688 +10
- Misses 11538 11563 +25
Partials 176 176 ☔ View full report in Codecov by Sentry. |
@@ -25,19 +25,18 @@ const useStyles = makeStyles()(theme => ({ | |||
highlight: { | |||
height: '100%', | |||
position: 'absolute', | |||
background: `${colord(theme.palette.quaternary?.main ?? 'goldenrod') | |||
overflow: 'hidden', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason for overflow: hidden being added here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without it, the icon on the highlight always shows (so if you're zoomed out and the highlight is a sliver you see it)
realistically, anything you're highlighting and looking at, you'd be a close enough zoom level to make use of the icon options, i think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good. i had this idea that possibly the link icon could even be hidden if the user is not hovering over, as the user might like it hidden for e.g. screenshot. just an idea though
fixed #4130 :) |
OverviewScalebarComponent
to accomplish thisOutlines for comparison (I think they might make the regions more visible in the overview scale bar):
Resolves #4246