Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix facet filter crash #4769

Merged
merged 1 commit into from
Jan 16, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -40,16 +40,18 @@ const FacetFilters = observer(function ({

let currentRows = rows
for (const facet of ret) {
const elt = uniqs.get(facet)!
for (const row of currentRows) {
const key = getRowStr(facet, row)
const val = elt.get(key)
// we don't allow filtering on empty yet
if (key) {
if (val === undefined) {
elt.set(key, 1)
} else {
elt.set(key, val + 1)
const elt = uniqs.get(facet)
if (elt) {
for (const row of currentRows) {
const key = getRowStr(facet, row)
const val = elt.get(key)
// we don't allow filtering on empty yet
if (key) {
if (val === undefined) {
elt.set(key, 1)
} else {
elt.set(key, val + 1)
}
}
}
}